WIP [IMPORTANT] replace every string in the codebase with "nigger" #9

Local testing suggests that the changes to files/__main__.py prevent vital acquisition of a database binding: the SQLALCHEMY_DATABASE_URL key is now nigger, which is set to be the environment variable nigger, which was not set in the env file.

While a valuable contribution in many other regards, this is a breaking change which cannot be merged in its present state.

Local testing suggests that the changes to `files/__main__.py` prevent vital acquisition of a database binding: the `SQLALCHEMY_DATABASE_URL` key is now `nigger`, which is set to be the environment variable `nigger`, which was not set in the `env` file. While a valuable contribution in many other regards, this is a breaking change which cannot be merged in its present state.

Snakes closed this pull request

2022-11-24 19:20:07 +00:00

UraniumDonGER commented

2022-11-24 19:58:36 +00:00

One variable to rule them all

N

One variable to rule them all # N

mummified-corroding-granny commented

2022-12-07 16:51:18 +00:00

I know this pull request still needs some more work before being reopened, but there is something crucial that was overlooked.

Next time, consider working on your abort() statements. There are occasions where you are using the following, when you should instead be using a 2XX return code. I am partial to 202 (Accepted), but open to debate

Considere replacing:

abort(403, "nigger")

with:

abort(202, "nigger")

🥈

I know this pull request still needs some more work before being reopened, but there is something crucial that was overlooked. Next time, consider working on your abort() statements. There are occasions where you are using the following, when you should instead be using a 2XX return code. I am partial to 202 (Accepted), but open to debate Considere replacing: ``` abort(403, "nigger") ``` with: ``` abort(202, "nigger") ``` 🥈

chiobu commented

2023-01-27 19:15:58 +00:00

Great PR

👀 1