rDrama
/
rDrama
9
10
Fork 7
Code Issues Pull Requests Packages Releases Wiki Activity

rework-awards #24

Closed
Aevann wants to merge 130 commits from <deleted>:rework-awards into master
pull from: <deleted>:rework-awards
merge into: rDrama:master
Conversation 0 Commits 130 Files Changed 78
Aevann commented 2022-11-27 23:45:01 +00:00
Owner
There is no content yet.
Aevann added 130 commits 2022-11-27 23:45:03 +00:00
4e59dc5b55
security: fix DoS on title getter 
the `timeout` parameter only applies to seconds per *byte* received (and time to first
byte), not the entire request

this means an attacker could theoretically send a very... slow...
stream... of... bytes... and... crash... the... worker... when... the...
timeout... is... reached...
8e04975144
submit: don't disable submit button by default 
this doesn't create an issue because HTML form validation does work here
98d53f217f
api: don't hit calc_users if this is the API 
sometimes we render HTML where we probably... shouldn't. in most cases
this is fine, but if API clients hit it it can errenously set
47df4e6c80
ranking: be site specific when boosting users or excluding users from boosts 
otherwise we may unintentionally rank for the wrong users (since we're using literal IDs)
39b578bba2
fix offline page scaling (#16) 
Co-authored-by: geese_suck <16601315+geese-suck@users.noreply.github.com>
Reviewed-on: #16
Co-authored-by: geese_suck <geese_suck@noreply.fsdfsd.net>
Co-committed-by: geese_suck <geese_suck@noreply.fsdfsd.net>
036afaecf8
log: fix word wrap bug 
log: remove network bloat by abt 10x
54cf53f1f5
Revert "user and" 
This reverts commit 0b146d0b7b.
0bcebc1700
Update chud award to include forced trans/pride flag hats (#10) 
Disclaimer: I made these changes in Notepad and didn't bother to test this change locally.
Co-authored-by: Marco <bussylmao@gmail.com>
Reviewed-on: #10
Co-authored-by: Marco <marco@noreply.fsdfsd.net>
Co-committed-by: Marco <marco@noreply.fsdfsd.net>
182c16f8a3
const: rename constants from LIMIT to MINIMUM 
the new name is much much clearer
Aevann closed this pull request 2022-11-27 23:50:30 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#24
There is no content yet.
Delete Branch "<deleted>:rework-awards"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?