rDrama
/
rDrama
9
10
Fork 6
Code Issues Pull Requests Packages Releases Wiki Activity

Update pride to use filter instead of colour, save on repaints #212

Closed
top wants to merge 3 commits from <deleted>:feature/top/pride-fix into master
pull from: <deleted>:feature/top/pride-fix
merge into: rDrama:master
Conversation 5 Commits 3 Files Changed 1
top commented 2023-10-06 19:26:40 +00:00

This seems to have significant performance increases based on the profiler anyways

This seems to have significant performance increases based on the profiler anyways
top added 1 commit 2023-10-06 19:26:41 +00:00
top force-pushed feature/top/pride-fix from 7276a4899f to 13aab85082 2023-10-06 19:35:18 +00:00 Compare
top commented 2023-10-06 19:35:51 +00:00
Poster

Updated to keep the part where it flashes the user's original color

Updated to keep the part where it flashes the user's original color
top commented 2023-10-06 19:37:13 +00:00
Poster

Edit: done

Edit: done
top added 1 commit 2023-10-06 19:46:59 +00:00
Aevann commented 2023-10-06 20:50:23 +00:00
Owner

the last version has the same CPU usage as my original implementation

I implemented an earlier version of ur code that reduced CPU usage by around 50% 8e6e8e1e50

image

the last version has the same CPU usage as my original implementation I implemented an earlier version of ur code that reduced CPU usage by around 50% https://fsdfsd.net/rDrama/rDrama/commit/8e6e8e1e509ce120fb4829c137472133c6577b94 ![image](/attachments/cda04720-8fa6-439c-803d-4ee7a8ef055b)
image.png
33 KiB
top commented 2023-10-06 20:55:58 +00:00
Poster

Just note that the earlier version doesn't flash the user's username color like the current one does. It is way more performant though. The only way I can think to get around that without repainting if it's desired behavior is to perfectly overlap the pride box and just make it transparent for 20% of the animation.

Just note that the earlier version doesn't flash the user's username color like the current one does. It is way more performant though. The only way I can think to get around that without repainting if it's desired behavior is to perfectly overlap the pride box and just make it transparent for 20% of the animation.
top closed this pull request 2023-10-06 20:56:48 +00:00
Aevann commented 2023-10-07 00:41:18 +00:00
Owner

the earlier version doesn't flash the user's username color like the current one does

who cares lol

> the earlier version doesn't flash the user's username color like the current one does who cares lol
đŸ˜† 2

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#212
There is no content yet.
Delete Branch "<deleted>:feature/top/pride-fix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?