rDrama
/
rDrama
9
10
Fork 6
Code Issues Pull Requests Packages Releases Wiki Activity

Adds blackjack split #197

Merged
Aevann merged 5 commits from :top/feature/blackjack-split into master 2023-09-15 11:27:02 +00:00
Conversation 7 Commits 5 Files Changed 4
top commented 2023-09-04 04:13:57 +00:00

Holy shit this was a massive pain, done now though lol.

I recommend additional testing, I mean I did test this a ton locally but I also spent 3 hours fixing bugs and maybe missed something

Holy shit this was a massive pain, done now though lol. I recommend additional testing, I mean I did test this a ton locally but I also spent 3 hours fixing bugs and maybe missed something
top added 1 commit 2023-09-04 04:13:58 +00:00
top added 1 commit 2023-09-04 04:14:09 +00:00
top added 2 commits 2023-09-04 04:25:36 +00:00
top added 1 commit 2023-09-04 04:27:46 +00:00
top commented 2023-09-04 04:32:06 +00:00
Poster

Here's screenshot of what it looks like. It's a little tall, not much I can do about that with the current page design. Open to redesigning the page if you have ideas of how it should look

Here's screenshot of what it looks like. It's a little tall, not much I can do about that with the current page design. Open to redesigning the page if you have ideas of how it should look
Screenshot from 2023-09-03 21-31-10.png
82 KiB
Screenshot from 2023-09-03 21-31-10.png
top commented 2023-09-04 04:34:55 +00:00
Poster

I can add 5 card charlie after this, luckily that one is pretty easy to implement

I can add 5 card charlie after this, luckily that one is pretty easy to implement
transbitch commented 2023-09-05 16:35:53 +00:00

This doesn't implement splitting multiple times it looks like (usually you can split up to 3 times). Also what about doubling down after split?

I started working on splitting but never got around to finishing it. IIRC my backend is done, just the frontend needs work. My implementation allows for multiple splitting, doubling down etc. (it treats each split as another hand).

IMO I don't think this should be merged unless it can support splitting multiple times, but as always its up to Aevann.

This doesn't implement splitting multiple times it looks like (usually you can split up to 3 times). Also what about doubling down after split? I started working on splitting but never got around to finishing it. IIRC my backend is done, just the frontend needs work. My implementation allows for multiple splitting, doubling down etc. (it treats each split as another hand). IMO I don't think this should be merged unless it can support splitting multiple times, but as always its up to Aevann.
top commented 2023-09-05 20:16:14 +00:00
Poster

It depends on the casino, not all have a unified ruleset and there is no one "correct" ruleset for blackjack.

I didn't implement multiple splits cause it complicates the UI. Although since I've implemented this I have new ideas for how I can show the UI for multiple splits so I will actually look at adding it after work today.

As for double down after split, not all casinos allow that and it's certainly not universal. Multiple splits is more universal than double down after split.

It depends on the casino, not all have a unified ruleset and there is no one "correct" ruleset for blackjack. I didn't implement multiple splits cause it complicates the UI. Although since I've implemented this I have new ideas for how I can show the UI for multiple splits so I will actually look at adding it after work today. As for double down after split, not all casinos allow that and it's certainly not universal. Multiple splits is more universal than double down after split.
transbitch commented 2023-09-06 18:25:57 +00:00

double down after split increases EV

double down after split increases EV
top commented 2023-09-07 08:32:13 +00:00
Poster

I agree, double down after split shouldn't be added, improving the EV too much is how we ended up with https://rdrama.net/@blackjackbtz. Split technically also improves EV (extra splits to a lesser amount) but I guess it's fine if Aevann requested it

I agree, double down after split shouldn't be added, improving the EV too much is how we ended up with https://rdrama.net/@blackjackbtz. Split technically also improves EV (extra splits to a lesser amount) but I guess it's fine if Aevann requested it
transbitch commented 2023-09-09 01:21:31 +00:00

it doesnt increase it too much tho

it doesnt increase it too much tho
Aevann merged commit 30d10f638e into master 2023-09-15 11:27:02 +00:00
Aevann referenced this issue from a commit 2023-09-15 11:27:02 +00:00
Adds blackjack split (#197)
Aevann deleted branch top/feature/blackjack-split 2023-09-15 11:27:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#197
There is no content yet.
Delete Branch ":top/feature/blackjack-split"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?