Did the needful on Dockerfile to reduce number of layers in build process. #194

lain · 2023-08-12T21:20:13Z

lain commented

2023-08-12 21:20:13 +00:00

why

Depending on the command used in the Dockerfile (RUN, COPY) it will create a new layer.
Layers are useful for caching and I simplified the numbers of layers to take advantage of that.

this seems like a typo-fixing tier addition

it is and if I screwed something up unintentionally it'll break the build process. truly an amazing PR.
I really just wanted the badge.

Note: IMEI optimizations

Looking into the build process it looks like the IMEI script keeps the build dependencies around.
I tried poking around to see if I could remove only the build dependencies but I did not come to much of a conclusion.
At minimum uninstalling LLVM (I'm assuming that's a build dependency from a python package) and gcc would probably lower the docker image size a bit (~2.3GBs on my machine ATM).

I think the best course of action would be a multistage build with IMEI but I need to dig more into that. https://docs.docker.com/build/building/multi-stage/

## why Depending on the command used in the Dockerfile (RUN, COPY) it will create a new layer. Layers are useful for caching and I simplified the numbers of layers to take advantage of that. ## this seems like a typo-fixing tier addition it is and if I screwed something up unintentionally it'll break the build process. truly an amazing PR. I really just wanted the badge. ## Note: IMEI optimizations Looking into the build process it looks like the IMEI script *keeps* the build dependencies around. I tried poking around to see if I could remove *only* the build dependencies but I did not come to much of a conclusion. At minimum uninstalling LLVM (I'm assuming that's a build dependency from a python package) and gcc would probably lower the docker image size a bit (~2.3GBs on my machine ATM). I think the best course of action would be a multistage build with IMEI but I need to dig more into that. https://docs.docker.com/build/building/multi-stage/

lain added 1 commit 2023-08-12 21:20:14 +00:00

d58278047a Did the needful on Dockerfile to reduce number of layers in build process.

Aevann commented

2023-08-12 21:35:06 +00:00

there's a shitton of layers precisely because of caching, so if I add a new dependacy, it doesn't download all of them, just the one I added

Aevann closed this pull request

2023-08-12 21:35:06 +00:00