rDrama
/
rDrama
9
10
Fork 7
Code Issues Pull Requests Packages Releases Wiki Activity

Fixed issue where flipped talking wouldn't flip the marsey just the talking #179

Merged
Aevann merged 3 commits from top/bug/fix-flipped-talking into master 2023-08-05 01:49:52 +00:00
Conversation 2 Commits 3 Files Changed 3
top commented 2023-08-04 21:49:55 +00:00

-Also made the preview work closer to the actual behavior from the server.
-Fixed issue where multiple talking or pats would remove all instances rather than just the one from the end.
-Added a hidden feature to double flip the talking bubble (for non-patted emotes).
-Made the pat look better with the talking when -pattalking emotes are shown.
-Fixed issue with username mentions with pat or talking requiring the # or ! at the start.
-Now allows for # or ! to be within the talking or pat.

-Also made the preview work closer to the actual behavior from the server. -Fixed issue where multiple talking or pats would remove all instances rather than just the one from the end. -Added a hidden feature to double flip the talking bubble (for non-patted emotes). -Made the pat look better with the talking when -pattalking emotes are shown. -Fixed issue with username mentions with pat or talking requiring the # or ! at the start. -Now allows for # or ! to be within the talking or pat.
top added 2 commits 2023-08-04 21:49:55 +00:00
24c251409e Fixed an issue with flipped talking emotes being the wrong way 
Fixed an issue with username pat and talking requiring the # at the
start
Fixed many issues with the preview being inconsistent with the actual
server behaviour
Fixed issue where mulitple talkings and pats would be removed from the
emote, now talkingtalking should work
top requested review from Aevann 2023-08-04 21:49:59 +00:00
top changed title from Fixed issue where flipped talking wouldn't flip the marsey just the talking to WIP: Fixed issue where flipped talking wouldn't flip the marsey just the talking 2023-08-04 21:54:16 +00:00
top commented 2023-08-04 21:54:31 +00:00
Poster

Oop one issue I just noticed, shouldn't take long

Oop one issue I just noticed, shouldn't take long
top added 1 commit 2023-08-04 22:01:44 +00:00
top changed title from WIP: Fixed issue where flipped talking wouldn't flip the marsey just the talking to Fixed issue where flipped talking wouldn't flip the marsey just the talking 2023-08-04 22:01:46 +00:00
top commented 2023-08-04 22:02:03 +00:00
Poster

Fixed, looks like everything worked as I intended

Fixed, looks like everything worked as I intended
Aevann merged commit 1b4d70759b into master 2023-08-05 01:49:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Aevann
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#179
There is no content yet.
Delete Branch "top/bug/fix-flipped-talking"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?