rDrama
/
rDrama
9
10
Fork 7
Code Issues Pull Requests Packages Releases Wiki Activity

Fix /comment JSON response #167

Merged
Aevann merged 1 commits from :comment-json into master 2023-07-07 18:53:15 +00:00
Conversation 5 Commits 1 Files Changed 1
float-trip commented 2023-07-06 16:09:06 +00:00

Since replies is no longer added to the response, returning the JSON for the top level comment makes it impossible to get the JSON for a reply.

Btw - you might want to remove the author field here. It attaches the full user bio and badge list to every comment, which turns something like GET https://rdrama.net/post/18459 into a 21MB response. author_name is pretty much all anyone needs anyway

Since `replies` is no longer added to the response, returning the JSON for the top level comment makes it impossible to get the JSON for a reply. Btw - you might want to remove the `author` field [here](https://fsdfsd.net/rDrama/rDrama/src/commit/60b5b33a7932e8f4d29ca47364352540cf43566e/files/classes/comment.py#L308). It attaches the full user bio and badge list to every comment, which turns something like `GET https://rdrama.net/post/18459` into a 21MB response. `author_name` is pretty much all anyone needs anyway
float-trip added 1 commit 2023-07-06 16:09:07 +00:00
float-trip commented 2023-07-07 17:32:41 +00:00
Poster

Any issues with merging this? To elaborate, the problem is:

GET https://rdrama.net/comment/4526754 -> returns only the JSON for 4526754

GET https://rdrama.net/comment/4526930 -> returns only the JSON for 4526754

Seems unlikely anyone's relying on this behavior. The only way to get the JSON for 4526930 currently is from /comments or /notifications.

Any issues with merging this? To elaborate, the problem is: `GET https://rdrama.net/comment/4526754` -> returns only the JSON for `4526754` `GET https://rdrama.net/comment/4526930` -> returns only the JSON for `4526754` Seems unlikely anyone's relying on this behavior. The only way to get the JSON for `4526930` currently is from `/comments` or `/notifications`.
Aevann commented 2023-07-07 18:53:10 +00:00
Owner

no issues lol i was just busy

no issues lol i was just busy
Aevann merged commit 041481f2b6 into master 2023-07-07 18:53:15 +00:00
float-trip commented 2023-07-07 18:59:04 +00:00
Poster

My bad, ty

My bad, ty
float-trip deleted branch comment-json 2023-07-07 18:59:08 +00:00
Aevann commented 2023-07-08 18:26:23 +00:00
Owner

king i restored the replies field but made it return ids only instead of full json

king i restored the replies field but made it return ids only instead of full json
float-trip commented 2023-07-09 04:12:32 +00:00
Poster

Awesome, thanks

Awesome, thanks
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#167
There is no content yet.
Delete Branch ":comment-json"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?