Improve inline emoji modal #159

KindaCrayCray · 2023-06-30T02:46:47Z

KindaCrayCray commented

2023-06-30 02:46:47 +00:00

Fix/modernize keyboard navigation (making selections work and autoscroll)
Allow capital letters to be used in the inline emoji input
Fix first emoji typed not causing the picker to appear

- Fix/modernize keyboard navigation (making selections work and autoscroll) - Allow capital letters to be used in the inline emoji input - Fix first emoji typed not causing the picker to appear

KindaCrayCray added 5 commits 2023-06-30 02:46:48 +00:00

83a16bc090 Clean up emoji modal keyboard nav

Changed arrow keys to wrap around instead. Need to add autoscroll for
for the modal itself.

d1332f3387 Add scrolling when selected emoji is not visible

50849c8279 Casefold capital characters in inline search

f18716960a Fix first use of inline emoji picker not appearing

Previously, on the first use of the inline emoji modal, it would not
display the emojis because the display code would not wait for the
network request to resolve.

Now, the modal will appear when the emojis are successfully loaded and
then respond to the keystrokes.

a11e24a9ba Ignore case in emoji replacement

The capital letters from the user input could still be there since
current_word is lowercase

Aevann merged commit 3d5355e30f into master

2023-06-30 15:08:34 +00:00

Aevann referenced this issue from a commit

2023-06-30 15:08:34 +00:00

Improve inline emoji modal (#159)

Aevann referenced this issue from a commit

2023-06-30 17:31:47 +00:00

Revert "Improve inline emoji modal (#159)"

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#159