Add a button for enabling push notifications #158

borntolurk · 2023-06-28T00:48:00Z

borntolurk commented

2023-06-28 00:48:00 +00:00

Safari requires some user interaction to subscribe to push notifications (see this), so this PR adds a button to the navigation menu that requests notification permissions and does the subscription stuff. It also hides the "Mobile App" button from PWA

Side effect of this PR is that push permissions aren't gonna be requested automatically on other platforms anymore like they used to. Also it's probably a good idea to add this button somewhere else too because it's not very accessible on desktop

Safari requires some user interaction to subscribe to push notifications ([see this](https://developer.apple.com/documentation/usernotifications/sending_web_push_notifications_in_web_apps_safari_and_other_browsers)), so this PR adds a button to the navigation menu that requests notification permissions and does the subscription stuff. It also hides the "Mobile App" button from PWA Side effect of this PR is that push permissions aren't gonna be requested automatically on other platforms anymore like they used to. Also it's probably a good idea to add this button somewhere else too because it's not very accessible on desktop ![image](/attachments/f2f78028-9e5f-484f-aa98-59eb60e3ccd5)

push.png

74 KiB

image.png

47 KiB

borntolurk added 1 commit 2023-06-28 00:48:02 +00:00

4861136380 Add a button for enabling push notifications

Aevann merged commit 320a88a02b into master

2023-06-29 17:47:31 +00:00

Aevann referenced this issue from a commit

2023-06-29 17:47:31 +00:00

Add a button for enabling push notifications (#158)

Aevann referenced this issue from a commit