Kindly,
Just a small lil PR to make sure the chat counts keep synchronized in /chat as users come and go
Thanks,
granny
Reviewed-on: #122
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per $title:
* we add a button to the first column of each row of /formatting programatically
* programatically because table is subject to change and tedious/complicated to write it for each row
* clicking on button copies text of second row to clipboard (reusing toasts code)
* did some javascript replacing because of preserving newlines and removing extraneous tabs
Thanks,
granny
Reviewed-on: #120
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per $title. This is just a suggestion implementation
Whenever we click any marsey in the speed modal, it generates an error in developer tools console because markdown() is not defined. I suspect not being available is expected because that function is for re-rendering the markdown preview (????? when I look at chat code it is all spaghette to me)
Thanks,
granny
Reviewed-on: #119
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
* about the rdrama_rules, when I changed from http:// to https:// the other day, in some browsers it now displays the protocol tag which is ugly and inconsistent. Not sure why on some browsers it did not display "http://" before
* about the sorting: I will disable sorting on more table columns later on. This is all I can do right now
Reviewed-on: #112
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
We currently cannot see (toggle the dropdown/button) reports that are hidden behind the "show more" (comments) button. This PR fixes that.
Example of what is happening without this PR:
1. open megathread. The thread is long includes hundreds of comments implying need to click "show more" (comments) button
2. without clicking any "show more" (comments) button, click the flaggers button on one of the first comments
3. flaggers are presented as expected
4. click the "show more" (comments) button at the end
5. click the flaggers button on one of the comments that was hidden behind the "show more" (comments) button
6. the button does nothing and has no event listenner associated
With this PR:
1. all flaggers buttons work regardless if hidden behind "Show More" (comments) or not. Tested up to two "Show More" (comments) buttons
I did the PR this way because the view_more button calls register_new_elements() and not bottom.js as a whole
There are other things using data-toggleelement like the undelete button on comments and the Preview button on /submit. Both of those still work as expected
Reviewed-on: #111
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
I noticed there are some over-interactive tables in general on rdrama. Particularly, multiple columns in the shop tables (awards and hats), which allow you to sort by buttons, icons, … The one page for user profile views also comes to mind, because it uses relative time since last visit, is paged server-side and browsers do not know how to sort that type of data anyway.
Also I noticed there are some tables that have disabled sorting by using <td> instead of <th> for the headers as is the case of the following pages:
* @uid/followed
* @uid/following
All of these situations are accounted for but need to be changed later in a different PR, because I can't right now.
For example, the "Buy" column of the shop can be changed to the following to disable sorting:
`<th class="disable-sort-click">Buy</th>`
Reviewed-on: #107
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Aevann
mummified-corroding-granny