rDrama
/
rDrama
9
10
Fork 6
Code Issues Pull Requests Packages Releases Wiki Activity

add javascript and css for non-click-sortable table headers th #107

Merged
Aevann merged 1 commits from :add-feature-disable-table-th-sort-conditional into master 2023-02-01 14:10:11 +00:00
Conversation 0 Commits 1 Files Changed 2
mummified-corroding-granny commented 2023-02-01 00:18:20 +00:00

I noticed there are some over-interactive tables in general on rdrama. Particularly, multiple columns in the shop tables (awards and hats), which allow you to sort by buttons, icons, … The one page for user profile views also comes to mind, because it uses relative time since last visit, is paged server-side and browsers do not know how to sort that type of data anyway.

Also I noticed there are some tables that have disabled sorting by using instead of for the headers as is the case of the following pages:

  • @uid/followed
  • @uid/following

All of these situations are accounted for but need to be changed later in a different PR, because I can't right now.

For example, the "Buy" column of the shop can be changed to the following to disable sorting:

<th class="disable-sort-click">Buy</th>

I noticed there are some over-interactive tables in general on rdrama. Particularly, multiple columns in the shop tables (awards and hats), which allow you to sort by buttons, icons, … The one page for user profile views also comes to mind, because it uses relative time since last visit, is paged server-side and browsers do not know how to sort that type of data anyway. Also I noticed there are some tables that have disabled sorting by using <td> instead of <th> for the headers as is the case of the following pages: * @uid/followed * @uid/following All of these situations are accounted for but need to be changed later in a different PR, because I can't right now. For example, the "Buy" column of the shop can be changed to the following to disable sorting: `<th class="disable-sort-click">Buy</th>`
mummified-corroding-granny added 1 commit 2023-02-01 00:18:20 +00:00
Aevann merged commit 3a3e1d8d74 into master 2023-02-01 14:10:11 +00:00
mummified-corroding-granny deleted branch add-feature-disable-table-th-sort-conditional 2023-02-04 23:18:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#107
There is no content yet.
Delete Branch ":add-feature-disable-table-th-sort-conditional"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?