Multiple closely related issues:
- When sub_inactive_purge_task was moved to cron.py, a number of
imports were not added. Notably, missing helpers/alerts.py.
This led to hole inactivity deletions not taking place.
- However, this proved useful: the hole it's been trying to delete
the past few days was /h/changelog. This has now been excluded
from deletion.
- Finally, the missing import would've meant the monthly procoins
disbursement would fail when it runs in a couple days. This has
likewise been fixed.
At present, we typically distinguish links from other text by coloring
them, underlining on hover, and changing cursor to pointer on hover.
However, when a post is glow-awarded, both color and underline-on-hover
are suppressed, making links very hard to find in text. Given chiobu's
tendency to glow award effortposts, this can make posts hard to read.
My solution is to always show links as underlined in glow-awarded posts
and comments. Not terribly attached to this particular approach, but
it seems to undermine the award effect the least while largely
restoring accessibility of links.
* formatmaxxing brained formatting
* formatmaxxing brained formatting: EPISODE 2
* Start implementing a .json interface for all logged users reddit-like
PROs:
- easier to debugmaxx applications
- good faith actors can scrap the site more easly :gigachadglow:
CONs:
- bad faith actors can scrap the site more easly :gigachadglow:
- jannitors lose a little of their power of allowlisting applications (they do it for free though)
anyways. I make this commit a separate commit so that Snakes can esclude it from the PR if he doesn't like it (cringe)
* /<username>/comments route now returns appropriate [citation needed] HTTP codes when called in JSON mode so that stupid JSON clients can crashmaxx
* More error codes (sorry I don't know how to squash)
* json endpoint. see other commit. I don't know how to squash
Apparently we stick the voting javascript in awards_modal.js, which
is included with awards_modal.html. While this makes sense as a proxy
for logged-in post-actions, it unfortunately means disabling inclusion
of the (otherwise unused) modal templates when FEATURES['AWARDS']
is disabled breaks other things.
Aevann1
Snakes
gooseman
DrTransmisia