Kindly,
Currently, the vote count at the top left of any post reserves too little space leading to many reflow situations when we vote on it:
* only happens on desktop version, considering the mobile website uses different layout/code
* happens whenever our vote changes the count between 9 to 10 (?), 99 to 100, 999 to 1000. Also happens in more common situations like 81 to 82 and :marseymanysuchcases:
I did a minimalist approach by removing the margin, reserving just enough width (values between -XXX and XXXX) and lowering the vote buttons to minimize hat collision. Arguably, the vote buttons look better with the PR, because they are centered with flairs (WPD) and less off-center on rdrama with post rewards, pfp, ...
Net excess of ~10px, which I feel is borderline too much
Thanks,
granny
Reviewed-on: #131
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
In most pages where there are tables containing usernames, there is a space between the user icon and the username that gets underlined on hover. It happens in most tables in this app (applies both to rdrama and WPD). That automatic whitepace appears to come from the usual HTML default space between inline elements. The alternative is to change inheritence but appears cumbersome.
This PR fixes that.
Affected pages (those that render user_in_table.html):
./files/templates/admin/alts.html
./files/templates/admin/loggedin.html
./files/templates/admin/lottery.html
./files/templates/admin/patrons.html
./files/templates/admin/shadowbanned.html
./files/templates/admins.html
./files/templates/banned.html
./files/templates/chuds.html
./files/templates/grassed.html
./files/templates/hats.html
./files/templates/leaderboard.html
./files/templates/marseys.html
./files/templates/poll_votes.html
./files/templates/settings/security.html
./files/templates/special/worldcup22_leaderboard.html
./files/templates/sub/blockers.html
./files/templates/sub/exilees.html
./files/templates/sub/mods.html
./files/templates/userpage/blockers.html
./files/templates/userpage/followers.html
./files/templates/userpage/following.html
./files/templates/userpage/views.html
./files/templates/userpage/voters.html
./files/templates/votes.html
Thanks,
Granny
Reviewed-on: #130
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
Suggesting to remove search bar from the top bar on this page because it just looks inconsistent/abandonware
The search thing does not even render on this page if on mobile or if we don't have a large enough monitor/res
Thanks,
granny
Reviewed-on: #127
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
$title
Whenever we click the "view entire discussion" we want to see more comments and not be sent to the top of the page.
This PR fixes that by sending us to the dropdown sort button just above the comments section.
Thanks,
granny
Reviewed-on: #124
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
Just a small lil PR to make sure the chat counts keep synchronized in /chat as users come and go
Thanks,
granny
Reviewed-on: #122
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per $title:
* we add a button to the first column of each row of /formatting programatically
* programatically because table is subject to change and tedious/complicated to write it for each row
* clicking on button copies text of second row to clipboard (reusing toasts code)
* did some javascript replacing because of preserving newlines and removing extraneous tabs
Thanks,
granny
Reviewed-on: #120
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
This is follow-up work to #110 where I target post comments.
This fixes element spliting for "Edited X ago", reply arrow + name and lottery icon + lottery message
Thanks,
granny
Reviewed-on: #118
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
follow-up work to PR #114 . Very useful to reduce extraneous scrolling especially for very long profiles (e.g. @chiobu). Not like I can read that profile anyway
Reviewed-on: #116
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
As per title. Especially useful on long posts both in mobile and desktop so that we don't have to scroll through the long post ater each change.
Don't have time for anything else today. Added to my list to analyze if we can add this skip in other pages especially those that have this same button
Reviewed-on: #114
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per title
granny
Reviewed-on: #113
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
* about the rdrama_rules, when I changed from http:// to https:// the other day, in some browsers it now displays the protocol tag which is ugly and inconsistent. Not sure why on some browsers it did not display "http://" before
* about the sorting: I will disable sorting on more table columns later on. This is all I can do right now
Reviewed-on: #112
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
prevent/minimize meta elements getting split between multiple lines in post meta:
* posted relative time: 2m ago
* type (youtube.com)
* edited: x time ago
* views: 5 thread views
While this is not common for your average post with low ammount of awards on a 1080p desktop, it is especially bad:
* on mobile for most posts
* users with different system zoom
* on posts popular posts
* when the poster has a long flair
Reviewed-on: #110
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
fix-small-tisms that I had piled up in my todo
Reviewed-on: #109
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
* the advanced search dropdown (was dropping up depending on layout) was covering the search bar. This makes sure it always drops down. Works fine on small screens (mobile)
* this is complementary to #96 with exception to the rare edge case that is happening before this new PR. The edge case is under some very specific combination of resolution + zoom, where the advanced search was partially going under the navbar because there are already some unknown z-index contexts in that area. In that case, it was impossible to fix with increasing z-index because we would just go back to the original problem or worse
Reviewed-on: #106
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Small lil PR:
* slots comment command was on the first column of the table which is for descriptions
* added a small description because the table looked weird due to the rows being shorter than the surrounding ones. Could have gone with a colspan but I guess it is useful information that the winnings are of the same type of currency
Reviewed-on: #105
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
this is fine :marseyclueless:
Reviewed-on: #95
Co-authored-by: geese_suck <deandre.williams@geese-suck.us>
Co-committed-by: geese_suck <deandre.williams@geese-suck.us>
As per title "Stop skipping render of Follow/Unfollow button in user listing because profile is private"
Happens when browsing through the user listing (at least):
* /search/users
* /users
Seems strange to hide that button in the user listing and not the profile page itself. When profiles are private, there can be some interest in following/unfollowing even without clicking the profile. Tried to search git history but no additional sense was obtained
Co-authored-by: Your Name <madmarcolas@gmail.com>
Reviewed-on: #94
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
This fixes it but using the HOLE_NAME in const.py . Not sure if it applies to other things other than WPD/RDRAMA.
Tested only for RDRAMA because I do not have a WPD instance
Co-authored-by: Your Name <madmarcolas@gmail.com>
Reviewed-on: #91
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Aevann
mummified-corroding-granny
SneedBot
geese_suck