rDrama
/
rDrama
9
10
Fork 6
Code Issues Pull Requests Packages Releases Wiki Activity

user tables: add float plus margins to replace whitespace #130

Merged
Aevann merged 1 commits from :fix-tables-username-underlining-hover-space into master 2023-02-21 14:21:46 +00:00
Conversation 0 Commits 1 Files Changed 2
mummified-corroding-granny commented 2023-02-21 01:12:39 +00:00

Kindly,

In most pages where there are tables containing usernames, there is a space between the user icon and the username that gets underlined on hover. It happens in most tables in this app (applies both to rdrama and WPD). That automatic whitepace appears to come from the usual HTML default space between inline elements. The alternative is to change inheritence but appears cumbersome.

This PR fixes that.

Affected pages (those that render user_in_table.html):

./files/templates/admin/alts.html
./files/templates/admin/loggedin.html
./files/templates/admin/lottery.html
./files/templates/admin/patrons.html
./files/templates/admin/shadowbanned.html
./files/templates/admins.html
./files/templates/banned.html
./files/templates/chuds.html
./files/templates/grassed.html
./files/templates/hats.html
./files/templates/leaderboard.html
./files/templates/marseys.html
./files/templates/poll_votes.html
./files/templates/settings/security.html
./files/templates/special/worldcup22_leaderboard.html
./files/templates/sub/blockers.html
./files/templates/sub/exilees.html
./files/templates/sub/mods.html
./files/templates/userpage/blockers.html
./files/templates/userpage/followers.html
./files/templates/userpage/following.html
./files/templates/userpage/views.html
./files/templates/userpage/voters.html
./files/templates/votes.html

Thanks,
Granny

Kindly, In most pages where there are tables containing usernames, there is a space between the user icon and the username that gets underlined on hover. It happens in most tables in this app (applies both to rdrama and WPD). That automatic whitepace appears to come from the usual HTML default space between inline elements. The alternative is to change inheritence but appears cumbersome. This PR fixes that. Affected pages (those that render user_in_table.html): ./files/templates/admin/alts.html ./files/templates/admin/loggedin.html ./files/templates/admin/lottery.html ./files/templates/admin/patrons.html ./files/templates/admin/shadowbanned.html ./files/templates/admins.html ./files/templates/banned.html ./files/templates/chuds.html ./files/templates/grassed.html ./files/templates/hats.html ./files/templates/leaderboard.html ./files/templates/marseys.html ./files/templates/poll_votes.html ./files/templates/settings/security.html ./files/templates/special/worldcup22_leaderboard.html ./files/templates/sub/blockers.html ./files/templates/sub/exilees.html ./files/templates/sub/mods.html ./files/templates/userpage/blockers.html ./files/templates/userpage/followers.html ./files/templates/userpage/following.html ./files/templates/userpage/views.html ./files/templates/userpage/voters.html ./files/templates/votes.html Thanks, Granny
disorder.png
88 KiB
disorder.png
mummified-corroding-granny added 1 commit 2023-02-21 01:12:40 +00:00
Aevann merged commit c51261aab3 into master 2023-02-21 14:21:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
feature

New feature   
good first issue

New and want to help?   
help wanted

Need some help   
improvement

Code-focused: maintenance, refactoring   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
feature
good first issue
help wanted
improvement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rDrama/rDrama#130
There is no content yet.
Delete Branch ":fix-tables-username-underlining-hover-space"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?