Safari requires some user interaction to subscribe to push notifications ([see this](https://developer.apple.com/documentation/usernotifications/sending_web_push_notifications_in_web_apps_safari_and_other_browsers)), so this PR adds a button to the navigation menu that requests notification permissions and does the subscription stuff. It also hides the "Mobile App" button from PWA
Side effect of this PR is that push permissions aren't gonna be requested automatically on other platforms anymore like they used to. Also it's probably a good idea to add this button somewhere else too because it's not very accessible on desktop
![image](/attachments/f2f78028-9e5f-484f-aa98-59eb60e3ccd5)
Co-authored-by: borntolurk <borntolurk@rdrama.net>
Reviewed-on: rDrama/rDrama#158
Co-authored-by: borntolurk <borntolurk@noreply.fsdfsd.net>
Co-committed-by: borntolurk <borntolurk@noreply.fsdfsd.net>
* about the rdrama_rules, when I changed from http:// to https:// the other day, in some browsers it now displays the protocol tag which is ugly and inconsistent. Not sure why on some browsers it did not display "http://" before
* about the sorting: I will disable sorting on more table columns later on. This is all I can do right now
Reviewed-on: rDrama/rDrama#112
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
We currently cannot see (toggle the dropdown/button) reports that are hidden behind the "show more" (comments) button. This PR fixes that.
Example of what is happening without this PR:
1. open megathread. The thread is long includes hundreds of comments implying need to click "show more" (comments) button
2. without clicking any "show more" (comments) button, click the flaggers button on one of the first comments
3. flaggers are presented as expected
4. click the "show more" (comments) button at the end
5. click the flaggers button on one of the comments that was hidden behind the "show more" (comments) button
6. the button does nothing and has no event listenner associated
With this PR:
1. all flaggers buttons work regardless if hidden behind "Show More" (comments) or not. Tested up to two "Show More" (comments) buttons
I did the PR this way because the view_more button calls register_new_elements() and not bottom.js as a whole
There are other things using data-toggleelement like the undelete button on comments and the Preview button on /submit. Both of those still work as expected
Reviewed-on: rDrama/rDrama#111
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>