Kindly,
As per $title.
Currently, if a user changes name or color while in chat, the username will stick forever (until clearing all sessions with a process restart).
This PR fxes both of these situations. The code is getting ugly and would benefit from using dictionaries instead of lists, but I suspect there are other priorities.
Thanks,
granny
Reviewed-on: rDrama/rDrama#123
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
Not sure if this is too dramaphobic. I also went with the just enough (TM) approach
The issue this PR intends to fix:
1. user has no chat tabs open
2. user opens two chat tabs
3. user closes second chat tab
4. user disappears from sidebar and user count (because was removed from online py list)
5. user (became shadow user) can now spy on the chat without being listed
Thanks,
granny
Reviewed-on: rDrama/rDrama#121
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
Just a small lil PR to make sure the chat counts keep synchronized in /chat as users come and go
Thanks,
granny
Reviewed-on: rDrama/rDrama#122
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per $title:
* we add a button to the first column of each row of /formatting programatically
* programatically because table is subject to change and tedious/complicated to write it for each row
* clicking on button copies text of second row to clipboard (reusing toasts code)
* did some javascript replacing because of preserving newlines and removing extraneous tabs
Thanks,
granny
Reviewed-on: rDrama/rDrama#120
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
This is follow-up work to rDrama/rDrama#110 where I target post comments.
This fixes element spliting for "Edited X ago", reply arrow + name and lottery icon + lottery message
Thanks,
granny
Reviewed-on: rDrama/rDrama#118
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per $title. This is just a suggestion implementation
Whenever we click any marsey in the speed modal, it generates an error in developer tools console because markdown() is not defined. I suspect not being available is expected because that function is for re-rendering the markdown preview (????? when I look at chat code it is all spaghette to me)
Thanks,
granny
Reviewed-on: rDrama/rDrama#119
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
Seems strange that posts can use nested lists with increased padding at each level while comments do not have any padding on the nested lists
EDIT: disregard branch name. A bit tipsy and just used the branch that I had in my hand
Reviewed-on: rDrama/rDrama#117
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
follow-up work to PR #114 . Very useful to reduce extraneous scrolling especially for very long profiles (e.g. @chiobu). Not like I can read that profile anyway
Reviewed-on: rDrama/rDrama#116
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
As per title. Especially useful on long posts both in mobile and desktop so that we don't have to scroll through the long post ater each change.
Don't have time for anything else today. Added to my list to analyze if we can add this skip in other pages especially those that have this same button
Reviewed-on: rDrama/rDrama#114
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Kindly,
As per title
granny
Reviewed-on: rDrama/rDrama#113
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
* about the rdrama_rules, when I changed from http:// to https:// the other day, in some browsers it now displays the protocol tag which is ugly and inconsistent. Not sure why on some browsers it did not display "http://" before
* about the sorting: I will disable sorting on more table columns later on. This is all I can do right now
Reviewed-on: rDrama/rDrama#112
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
We currently cannot see (toggle the dropdown/button) reports that are hidden behind the "show more" (comments) button. This PR fixes that.
Example of what is happening without this PR:
1. open megathread. The thread is long includes hundreds of comments implying need to click "show more" (comments) button
2. without clicking any "show more" (comments) button, click the flaggers button on one of the first comments
3. flaggers are presented as expected
4. click the "show more" (comments) button at the end
5. click the flaggers button on one of the comments that was hidden behind the "show more" (comments) button
6. the button does nothing and has no event listenner associated
With this PR:
1. all flaggers buttons work regardless if hidden behind "Show More" (comments) or not. Tested up to two "Show More" (comments) buttons
I did the PR this way because the view_more button calls register_new_elements() and not bottom.js as a whole
There are other things using data-toggleelement like the undelete button on comments and the Preview button on /submit. Both of those still work as expected
Reviewed-on: rDrama/rDrama#111
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
prevent/minimize meta elements getting split between multiple lines in post meta:
* posted relative time: 2m ago
* type (youtube.com)
* edited: x time ago
* views: 5 thread views
While this is not common for your average post with low ammount of awards on a 1080p desktop, it is especially bad:
* on mobile for most posts
* users with different system zoom
* on posts popular posts
* when the poster has a long flair
Reviewed-on: rDrama/rDrama#110
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
fix-small-tisms that I had piled up in my todo
Reviewed-on: rDrama/rDrama#109
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
https://scottaaronson.blog/ is a thing, for example. We must support the thing.
Add .blog as an approved TLD.
Co-authored-by: official-techsupport <official_techsupport@protonmail.com>
Reviewed-on: rDrama/rDrama#108
Co-authored-by: official-techsupport <official-techsupport@noreply.fsdfsd.net>
Co-committed-by: official-techsupport <official-techsupport@noreply.fsdfsd.net>
I noticed there are some over-interactive tables in general on rdrama. Particularly, multiple columns in the shop tables (awards and hats), which allow you to sort by buttons, icons, … The one page for user profile views also comes to mind, because it uses relative time since last visit, is paged server-side and browsers do not know how to sort that type of data anyway.
Also I noticed there are some tables that have disabled sorting by using <td> instead of <th> for the headers as is the case of the following pages:
* @uid/followed
* @uid/following
All of these situations are accounted for but need to be changed later in a different PR, because I can't right now.
For example, the "Buy" column of the shop can be changed to the following to disable sorting:
`<th class="disable-sort-click">Buy</th>`
Reviewed-on: rDrama/rDrama#107
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
* the advanced search dropdown (was dropping up depending on layout) was covering the search bar. This makes sure it always drops down. Works fine on small screens (mobile)
* this is complementary to rDrama/rDrama#96 with exception to the rare edge case that is happening before this new PR. The edge case is under some very specific combination of resolution + zoom, where the advanced search was partially going under the navbar because there are already some unknown z-index contexts in that area. In that case, it was impossible to fix with increasing z-index because we would just go back to the original problem or worse
Reviewed-on: rDrama/rDrama#106
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>