Improve inline emoji modal (with bugfixes) #162

KindaCrayCray · 2023-06-30T22:55:09Z

KindaCrayCray commented

2023-06-30 22:55:09 +00:00

Fix/modernize keyboard navigation (making selections work and autoscroll)
Allow capital letters to be used in the inline emoji input
Fix first emoji typed not causing the picker to appear

*Fixed bug that broke emoji pickers

- Fix/modernize keyboard navigation (making selections work and autoscroll) - Allow capital letters to be used in the inline emoji input - Fix first emoji typed not causing the picker to appear \*Fixed bug that broke emoji pickers

KindaCrayCray added 7 commits 2023-06-30 22:55:10 +00:00

bc8a3dcb9d Clean up emoji modal keyboard nav

Changed arrow keys to wrap around instead. Need to add autoscroll for
for the modal itself.

cfc6f9c4b2 Add scrolling when selected emoji is not visible

f88cd9d8a1 Casefold capital characters in inline search

2cd167b9fa Fix first use of inline emoji picker not appearing

Previously, on the first use of the inline emoji modal, it would not
display the emojis because the display code would not wait for the
network request to resolve.

Now, the modal will appear when the emojis are successfully loaded and
then respond to the keystrokes.

98a2ade30b Ignore case in emoji replacement

The capital letters from the user input could still be there since
current_word is lowercase

33bc341466 Fix emoji input menu not entering emojis

Problem was that we removed the parameter for the loadEmojis function
because we didn't do a full text search on the entire codebase to see
where it was actually used.

Also changed loading to reject the promise to ignore later keystrokes
while the modal is still loading.

668f5c8536 Update old comment

Aevann merged commit fedb366b6b into master

2023-07-01 00:04:24 +00:00

Aevann referenced this issue from a commit

2023-07-01 00:04:24 +00:00

Improve inline emoji modal (with bugfixes) (#162)

Sign in to join this conversation.

No reviewers