Chat: pending issues with user rename #133

New Issue

mummified-corroding-granny · 2023-02-23T02:04:15Z

mummified-corroding-granny commented

2023-02-23 02:04:15 +00:00

Kindly,

These are at least two minor left over issues because the chat code is currently very minimalistic:

left-over "typing" usernames for users that are no longer online. This an edge case that was already present before the sessions code was implemented and I did not add code to cover this case:
1. join chat in a single tab (this procedure only involves one chat tab)
2. change name in settings
3. start typing in chat and do not press enter
- shows new name in "typing", while the sidebar still shows the old name (as expected with current code)
1. close tab
- removes old name
current state of user rename in sidebar (online py list):
- after user renames in settings, next comment he writes (if not chained on previous comments) will use the new name
- sidebar never updates because it is currently updating only when people join chat. Does update on all chat tabs if this user opens a new chat tab

I am a bit overworked this week so I might take this on after the fires stop burning

Thanks,
granny

Kindly, These are at least two minor left over issues because the chat code is currently very minimalistic: * left-over "typing" usernames for users that are no longer online. This an edge case that was already present before the sessions code was implemented and I did not add code to cover this case: 1. join chat in a single tab (this procedure only involves one chat tab) 2. change name in settings 3. start typing in chat and do not press enter * shows new name in "typing", while the sidebar still shows the old name (as expected with current code) 4. close tab * removes old name * current state of user rename in sidebar (online py list): * after user renames in settings, next comment he writes (if not chained on previous comments) will use the new name * sidebar never updates because it is currently updating only when people join chat. Does update on all chat tabs if this user opens a new chat tab I am a bit overworked this week so I might take this on after the fires stop burning Thanks, granny

Aevann commented

2023-08-12 11:15:28 +00:00

not rly a problem lol who cares

🚀 1

Aevann closed this issue

2023-08-12 11:15:28 +00:00

Sign in to join this conversation.