This reverts commit 129f335363.
If there exists a loop in alts, this sends a worker into an infinite
loop, thrashes the database, and eventually crashes the worker. This,
in practice, makes shadowbanning people with many alts impossible since
our alt linking algorithm almost explicitly creates cycles rather than
maintaining a tree.
To fix this, we need SQL that builds a set of all Users in the
connected Alt graph of a given user (likely using a recursive CTE)
and then bans them at once, rather than running a depth-first search
with maximum depth that doesn't remember previously visited nodes.
There is also potentially the chance that this isn't because of cycles
per se but rather because quintic polynomial behavior explodes quickly
even in the low-double-digits number of alts.
messages got borked completely by this commit
this reverts commit b649a16b46.
---
Snakes note: DM and modmail replies 404'd because dispatched
to the wrong endpoint. The fix to that affected cancel buttons
in some contexts, so this PR also fixes those. Cancel button
presence and behavior should be same as it was a ~week ago
(i.e. correct), and all reply everywhere seem to work right.
Co-authored-by: justcool393 <justcool393@gmail.com>
Reviewed-on: #65
Co-authored-by: justcool393 <justcool393@noreply.fsdfsd.net>
Co-committed-by: justcool393 <justcool393@noreply.fsdfsd.net>
This reverts commit a9309096b4.
This doesn't fix the modmail bug in all contexts and introduces a bug
in another. Root cause is that POST /comments is sometimes called by
DM reply boxes (rather than POST /@<username>/message), revert pending
fix.
Aevann1
SneedBot
Snakes
justcool393