From e9a15cd0b8424b329864cf06c7bb31acf2ec162f Mon Sep 17 00:00:00 2001
From: Aevann <randomname42029@gmail.com>
Date: Thu, 2 Mar 2023 21:21:38 +0200
Subject: [PATCH] disallow creating !everyone

---
 files/routes/groups.py | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/files/routes/groups.py b/files/routes/groups.py
index 528306fe8..8c8d8e471 100644
--- a/files/routes/groups.py
+++ b/files/routes/groups.py
@@ -28,29 +28,30 @@ def create_group(v):
 	if not valid_sub_regex.fullmatch(name):
 		return redirect(f"/ping_groups?error=Name does not match the required format!")
 
-	group = g.db.get(Group, name)
-	if not group:
-		if not v.charge_account('coins', GROUP_COST):
-			return redirect(f"/ping_groups?error=You don't have enough coins!")
+	if name == 'everyone' or g.db.get(Group, name):
+		return redirect(f"/ping_groups?error=This group already exists!")
 
-		g.db.add(v)
-		if v.shadowbanned: abort(500)
+	if not v.charge_account('coins', GROUP_COST):
+		return redirect(f"/ping_groups?error=You don't have enough coins!")
 
-		group = Group(name=name)
-		g.db.add(group)
-		g.db.flush()
+	g.db.add(v)
+	if v.shadowbanned: abort(500)
 
-		group_membership = GroupMembership(
-			user_id=v.id,
-			group_name=group.name,
-			created_utc=time.time(),
-			approved_utc=time.time()
-			)
-		g.db.add(group_membership)
+	group = Group(name=name)
+	g.db.add(group)
+	g.db.flush()
 
-		admins = [x[0] for x in g.db.query(User.id).filter(User.admin_level >= PERMS['NOTIFICATIONS_HOLE_CREATION'], User.id != v.id).all()]
-		for admin in admins:
-			send_repeatable_notification(admin, f":!marseyparty: !{group} has been created by @{v.username} :marseyparty:")
+	group_membership = GroupMembership(
+		user_id=v.id,
+		group_name=group.name,
+		created_utc=time.time(),
+		approved_utc=time.time()
+		)
+	g.db.add(group_membership)
+
+	admins = [x[0] for x in g.db.query(User.id).filter(User.admin_level >= PERMS['NOTIFICATIONS_HOLE_CREATION'], User.id != v.id).all()]
+	for admin in admins:
+		send_repeatable_notification(admin, f":!marseyparty: !{group} has been created by @{v.username} :marseyparty:")
 
 	return redirect(f'/ping_groups?msg=!{group} created successfully!')