From 23c11fa7b7ae3fbb9d75f1c5b00ac5f755287015 Mon Sep 17 00:00:00 2001
From: mummified-corroding-granny
 <mummified-corroding-granny@noreply.fsdfsd.net>
Date: Wed, 1 Feb 2023 14:09:34 +0000
Subject: [PATCH 1/2] search page: always force advanced search to dropdown to
 avoid overlap searchbar (#106)

* the advanced search dropdown (was dropping up depending on layout) was covering the search bar. This makes sure it always drops down. Works fine on small screens (mobile)
* this is complementary to https://fsdfsd.net/rDrama/rDrama/pulls/96 with exception to the rare edge case that is happening before this new PR. The edge case is under some very specific combination of resolution + zoom, where the advanced search was partially going under the navbar because there are already some unknown z-index contexts in that area. In that case, it was impossible to fix with increasing z-index because we would just go back to the original problem or worse

Reviewed-on: https://fsdfsd.net/rDrama/rDrama/pulls/106
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
---
 files/templates/search.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/files/templates/search.html b/files/templates/search.html
index 80054bc0b..57e7671ad 100644
--- a/files/templates/search.html
+++ b/files/templates/search.html
@@ -31,7 +31,7 @@
 				<div class="pl-md-3">
 					{% if not request.path.startswith('/search/users') %}
 						<div id="searchparams-dropdown" class="dropdown dropdown-actions">
-							<button type="button" class="btn btn-secondary dropdown-toggle" id="dropdownMenuButton2" data-bs-toggle="dropdown"><strong>Advanced search parameters (with examples)</strong></button>
+							<button type="button" class="btn btn-secondary dropdown-toggle" id="dropdownMenuButton2" data-bs-toggle="dropdown" data-bs-display="static"><strong>Advanced search parameters (with examples)</strong></button>
 							<div class="dropdown-menu" x-placement="bottom-start" style="position: absolute; will-change: transform; top: 0px; left: 0px; transform: translate3d(0px, 31px, 0px);">
 								<div>
 									<div style="display: inline-block; width: 150px; text-align: center;">Author:</div>

From 3a3e1d8d74fd8f3c8e8aa8b2d413479bd0993dd0 Mon Sep 17 00:00:00 2001
From: mummified-corroding-granny
 <mummified-corroding-granny@noreply.fsdfsd.net>
Date: Wed, 1 Feb 2023 14:10:10 +0000
Subject: [PATCH 2/2] add javascript and css for non-click-sortable table
 headers th (#107)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I noticed there are some over-interactive tables in general on rdrama. Particularly, multiple columns in the shop tables (awards and hats), which allow you to sort by buttons, icons, … The one page for user profile views also comes to mind, because it uses relative time since last visit, is paged server-side and browsers do not know how to sort that type of data anyway.

Also I noticed there are some tables that have disabled sorting by using <td> instead of <th> for the headers as is the case of the following pages:
* @uid/followed
* @uid/following

All of these situations are accounted for but need to be changed later in a different PR, because I can't right now.

For example, the "Buy" column of the shop can be changed to the following to disable sorting:

`<th class="disable-sort-click">Buy</th>`

Reviewed-on: https://fsdfsd.net/rDrama/rDrama/pulls/107
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
---
 files/assets/css/main.css | 4 ++++
 files/assets/js/core.js   | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/files/assets/css/main.css b/files/assets/css/main.css
index bbe62e1ad..e8468c5f4 100644
--- a/files/assets/css/main.css
+++ b/files/assets/css/main.css
@@ -5120,6 +5120,10 @@ code {
 	cursor: pointer !important;
 }
 
+.disable-sort-click {
+	cursor: default !important;
+}
+
 lite-youtube {
 	background-color: #000;
 	position: relative;
diff --git a/files/assets/js/core.js b/files/assets/js/core.js
index 3ef0dceae..c1ce93f83 100644
--- a/files/assets/js/core.js
+++ b/files/assets/js/core.js
@@ -548,6 +548,9 @@ if (reload_page) {
 
 const TH = document.getElementsByTagName('th')
 for (const element of TH) {
+	if (element.classList.contains("disable-sort-click"))
+                continue;
+
 	element.addEventListener('click', () => {sort_table(element)});
 }