rDrama
/
rDrama
9
10
Fork 7
Code Issues Pull Requests Packages Releases Wiki Activity

chat: prevent usernames sticking after rename and color change (#123) 

Kindly,

As per $title.

Currently, if a user changes name or color while in chat, the username will stick forever (until clearing all sessions with a process restart).

This PR fxes both of these situations. The code is getting ugly and would benefit from using dictionaries instead of lists, but I suspect there are other priorities.

Thanks,
granny

Reviewed-on: #123
Co-authored-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
Co-committed-by: mummified-corroding-granny <mummified-corroding-granny@noreply.fsdfsd.net>
pull/124/head
mummified-corroding-granny 2023-02-17 13:58:02 +00:00 committed by Aevann
parent 71c114ed52
commit 58e985525b
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
files/routes/chat.py
View File

@ -134,6 +134,12 @@ def refresh_online():
@admin_level_required(PERMS['CHAT'])
def connect(v):
if any(v.id in session for session in sessions) and [v.username, v.id, v.name_color] not in online:
# user has previous running sessions with a different username or name_color
for chat_user in online:
if(v.id == chat_user[1]):
online.remove(chat_user)
sessions.append([v.id, request.sid])
if [v.username, v.id, v.name_color] not in online:
online.append([v.username, v.id, v.name_color])
@ -148,16 +154,17 @@ def connect(v):
def disconnect(v):
if ([v.id, request.sid]) in sessions:
sessions.remove([v.id, request.sid])
if any(v.id in i for i in sessions):
if any(v.id in session for session in sessions):
# user has other running sessions
return '', 204
if [v.username, v.id, v.name_color] in online:
online.remove([v.username, v.id, v.name_color])
refresh_online()
for chat_user in online:
if(v.id == chat_user[1]):
online.remove(chat_user)
if chat_user[0] in typing:
typing.remove(chat_user[0])
if v.username in typing:
typing.remove(v.username)
refresh_online()
return '', 204