diff --git a/drama/classes/submission.py b/drama/classes/submission.py index 6ab17d076..84eb029b9 100644 --- a/drama/classes/submission.py +++ b/drama/classes/submission.py @@ -169,11 +169,9 @@ class Submission(Base, Stndrd, Age_times, Scores, Fuzzing): @lazy def domain(self): - if not self.url: - return "text post" + if not self.url: return "text post" domain = urlparse(self.url).netloc - if domain.startswith("www."): - domain = domain.split("www.")[1] + if domain.startswith("www."): domain = domain.split("www.")[1] return domain.replace("old.reddit.com", "reddit.com") def tree_comments(self, comment=None, v=None): @@ -209,8 +207,7 @@ class Submission(Base, Stndrd, Age_times, Scores, Fuzzing): def thumb_url(self): if self.over_18: return f"/assets/images/nsfw.png" - elif self.thumburl: return self.thumburl - else: return None + return self.thumburl @property @@ -410,7 +407,7 @@ class Submission(Base, Stndrd, Age_times, Scores, Fuzzing): @property def is_image(self): - if self.url: return self.url.lower().endswith('jpg') or self.url.lower().endswith('png') or self.url.lower().endswith('.gif') or self.url.lower().endswith('jpeg') or self.ur.lower().endswith('?maxwidth=9999') or self.url.lower().endswith('?maxwidth=8888') + if self.url: return self.url.lower().endswith('.jpg') or self.url.lower().endswith('.png') or self.url.lower().endswith('.gif') or self.url.lower().endswith('.jpeg') or self.url.lower().endswith('?maxwidth=9999') or self.url.lower().endswith('?maxwidth=8888') else: return False @property diff --git a/drama/routes/login.py b/drama/routes/login.py index 047e59aef..55653875f 100644 --- a/drama/routes/login.py +++ b/drama/routes/login.py @@ -275,17 +275,12 @@ def sign_up_post(v): return new_signup("Passwords did not match. Please try again.") # check username/pass conditions - if not re.match(valid_username_regex, username): - #print(f"signup fail - {username } - mismatched passwords") + if not re.fullmatch(valid_username_regex, username): return new_signup("Invalid username") - if not re.match(valid_password_regex, request.form.get("password")): - #print(f"signup fail - {username } - invalid password") + if not re.fullmatch(valid_password_regex, request.form.get("password")): return new_signup("Password must be between 8 and 100 characters.") - # if not re.match(valid_email_regex, request.form.get("email")): - # return new_signup("That's not a valid email.") - # Check for existing accounts email = request.form.get("email") email = email.strip() diff --git a/drama/templates/submission_listing.html b/drama/templates/submission_listing.html index 57b371825..740c1389a 100644 --- a/drama/templates/submission_listing.html +++ b/drama/templates/submission_listing.html @@ -63,27 +63,27 @@
- {% if p.thumb_url and p.is_image %} + {% if not p.realurl(v) %} + + text post thumbnail + + + {% elif p.is_image %} - {% elif p.thumb_url and not p.embed_url %} + {% elif p.thumb_url %} - {% elif p.embed_url %} + {% elif "youtu.be" in p.domain or "youtube.com" in p.domain %} - generic youtube embed thumbnail + generic youtube embed thumbnail - {% elif not p.realurl(v) %} - - text post thumbnail - - - {% elif p.realurl(v) and not p.thumb_url and not p.embed_url %} + {% else %} generic link post thumbnail