From 548ef45dbf58768a7b61518b54d7ad0d19fd81f6 Mon Sep 17 00:00:00 2001
From: justcool393 <justcool393@gmail.com>
Date: Fri, 9 Dec 2022 21:07:15 -0600
Subject: [PATCH] remove unnecessary check and try using the dialects type

---
 files/classes/sub.py   |  3 ++-
 files/helpers/media.py |  2 --
 files/routes/subs.py   | 11 ++++-------
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/files/classes/sub.py b/files/classes/sub.py
index 7df62c48e..68044d2aa 100644
--- a/files/classes/sub.py
+++ b/files/classes/sub.py
@@ -4,7 +4,8 @@ from typing import Optional
 
 from sqlalchemy import Column
 from sqlalchemy.orm import relationship
-from sqlalchemy.sql.sqltypes import *
+from sqlalchemy.types import VARCHAR, Boolean, Integer
+from sqlalchemy.dialects.postgresql import ARRAY
 
 from files.classes import Base
 from files.helpers.lazy import lazy
diff --git a/files/helpers/media.py b/files/helpers/media.py
index aa938f67f..93932cd14 100644
--- a/files/helpers/media.py
+++ b/files/helpers/media.py
@@ -124,8 +124,6 @@ def process_video(file, v):
 
 	return new
 
-
-
 def process_image(filename:str, v, resize=0, trim=False, uploader_id:Optional[int]=None, db=None):
 	# thumbnails are processed in a thread and not in the request context
 	# if an image is too large or webp conversion fails, it'll crash
diff --git a/files/routes/subs.py b/files/routes/subs.py
index 6ccc013c7..ff2e69a29 100644
--- a/files/routes/subs.py
+++ b/files/routes/subs.py
@@ -462,14 +462,11 @@ def upload_sub_banner(v:User, sub:str):
 	file.save(name)
 	bannerurl = process_image(name, v, resize=1200)
 
-	if bannerurl:
-		if sub.bannerurls:
-			sub.bannerurls.append(bannerurl)
-		else:
-			sub.bannerurls = [bannerurl]
-		g.db.add(sub)
+	if sub.bannerurls:
+		sub.bannerurls.append(bannerurl)
 	else:
-		abort(400, "No banner uploaded")
+		sub.bannerurls = [bannerurl]
+	g.db.add(sub)
 
 	ma = SubAction(
 		sub=sub.name,