From 40d7fc4b7177296322410eabb36b80e4fe60444d Mon Sep 17 00:00:00 2001 From: Aevann Date: Mon, 14 Aug 2023 17:29:06 +0300 Subject: [PATCH] replace innerText with less performance-heavy textContent --- files/assets/js/casino/game_screen.js | 12 ++++++------ files/assets/js/comments_v.js | 8 ++++---- files/assets/js/core.js | 4 ++-- files/assets/js/emoji_modal.js | 6 +++--- files/assets/js/lottery.js | 8 ++++---- files/assets/js/markdown.js | 2 +- files/assets/js/search.js | 2 +- files/assets/js/userpage_v.js | 16 ++++++++-------- 8 files changed, 29 insertions(+), 29 deletions(-) diff --git a/files/assets/js/casino/game_screen.js b/files/assets/js/casino/game_screen.js index 48c69c700..06be77060 100644 --- a/files/assets/js/casino/game_screen.js +++ b/files/assets/js/casino/game_screen.js @@ -12,13 +12,13 @@ function initializeGame() { function updatePlayerCurrencies(updated) { if (updated.coins) { - document.getElementById("user-coins-amount").innerText = updated.coins; - document.getElementById("user-coins-amount-casino").innerText = updated.coins; + document.getElementById("user-coins-amount").textContent = updated.coins; + document.getElementById("user-coins-amount-casino").textContent = updated.coins; } if (updated.marseybux) { - document.getElementById("user-bux-amount").innerText = updated.marseybux; - document.getElementById("user-bux-amount-casino").innerText = updated.marseybux; + document.getElementById("user-bux-amount").textContent = updated.marseybux; + document.getElementById("user-bux-amount-casino").textContent = updated.marseybux; } } @@ -48,14 +48,14 @@ function updateResult(text, className) { clearResult(); const result = document.getElementById("casinoGameResult"); result.style.visibility = "visible"; - result.innerText = text; + result.textContent = text; result.classList.add(`alert-${className}`); } function clearResult() { const result = document.getElementById("casinoGameResult"); result.style.visibility = "hidden"; - result.innerText = "N/A"; + result.textContent = "N/A"; result.classList.remove("alert-success", "alert-danger", "alert-warning"); } diff --git a/files/assets/js/comments_v.js b/files/assets/js/comments_v.js index 6f4af73d1..0373b063c 100644 --- a/files/assets/js/comments_v.js +++ b/files/assets/js/comments_v.js @@ -76,7 +76,7 @@ function toggleReplyBox(t, id) { let newHTML = '' if (t.innerHTML.includes('' - if (t.innerText) + if (t.textContent) newHTML += 'Quote selection' t.innerHTML = newHTML } @@ -220,13 +220,13 @@ function comment_edit(id){ if (data["ping_cost"]) { const ping_cost = document.getElementById('comment-ping-cost-' + id) - ping_cost.innerText = data["ping_cost"] + ping_cost.textContent = data["ping_cost"] ping_cost.parentElement.classList.remove('d-none') } if (data["edited_string"]) { const edited_string = document.getElementById('comment-edited_string-' + id) - edited_string.innerText = data["edited_string"] + edited_string.textContent = data["edited_string"] edited_string.parentElement.classList.remove('d-none') } @@ -371,7 +371,7 @@ function restore_reply_buttons(fullname) { let newHTML = '' if (t.innerHTML.includes('' - if (t.innerText) + if (t.textContent) newHTML += 'Reply' t.innerHTML = newHTML } diff --git a/files/assets/js/core.js b/files/assets/js/core.js index b84b22dc5..9ae8e0ef9 100644 --- a/files/assets/js/core.js +++ b/files/assets/js/core.js @@ -21,7 +21,7 @@ function showToast(success, message) { if (!message) { message = success ? "Action successful!" : "Error, please try again later"; } - document.getElementById(textElement).innerText = message; + document.getElementById(textElement).textContent = message; bootstrap.Toast.getOrCreateInstance(document.getElementById(element)).show(); } @@ -345,7 +345,7 @@ function sort_table(t) { } else if ('time' in x.dataset) { attr = parseInt(x.dataset.time); } else { - attr = x.innerText + attr = x.textContent if (/^[\d-,]+$/.test(x.innerHTML)) { attr = parseInt(attr.replace(/,/g, '')) } diff --git a/files/assets/js/emoji_modal.js b/files/assets/js/emoji_modal.js index 8a56b0d65..18fb16592 100644 --- a/files/assets/js/emoji_modal.js +++ b/files/assets/js/emoji_modal.js @@ -226,7 +226,7 @@ function fetchEmojis() { classSelectorLinkDOM.classList.add("nav-link", "emojitab"); classSelectorLinkDOM.dataset.bsToggle = "tab"; classSelectorLinkDOM.dataset.className = className; - classSelectorLinkDOM.innerText = className; + classSelectorLinkDOM.textContent = className; classSelectorLinkDOM.addEventListener('click', switchEmojiTab); classSelectorDOM.appendChild(classSelectorLinkDOM); @@ -333,7 +333,7 @@ function update_ghost_div_textarea(text) let ghostdiv = text.parentNode.querySelector(".ghostdiv"); if (!ghostdiv) return; - ghostdiv.innerText = text.value.substring(0, text.selectionStart); + ghostdiv.textContent = text.value.substring(0, text.selectionStart); ghostdiv.insertAdjacentHTML('beforeend', ""); @@ -411,7 +411,7 @@ function populate_speed_emoji_modal(results, textbox) if (emoji.count !== undefined) emoji_option_text.title += "\nused\t" + emoji.count; - emoji_option_text.innerText = name; + emoji_option_text.textContent = name; if (current_word.includes("#")) name = `#${name}` if (current_word.includes("!")) name = `!${name}` diff --git a/files/assets/js/lottery.js b/files/assets/js/lottery.js index dda364638..d3086a509 100644 --- a/files/assets/js/lottery.js +++ b/files/assets/js/lottery.js @@ -30,8 +30,8 @@ const lotteryOnReady = function () { ticketPurchaseQuantityInput.addEventListener("change", (event) => { const value = Math.max(1, parseInt(event.target.value)) purchaseQuantity = value - purchaseQuantityField.innerText = value - purchaseTotalCostField.innerText = value * 12 + purchaseQuantityField.textContent = value + purchaseTotalCostField.textContent = value * 12 }); }; @@ -76,7 +76,7 @@ function handleLotteryResponse(xhr, method, callback) { const toast = document.getElementById("lottery-post-success"); const toastMessage = document.getElementById("lottery-post-success-text"); - toastMessage.innerText = response.message; + toastMessage.textContent = response.message; bootstrap.Toast.getOrCreateInstance(toast).show(); @@ -86,7 +86,7 @@ function handleLotteryResponse(xhr, method, callback) { const toast = document.getElementById("lottery-post-error"); const toastMessage = document.getElementById("lottery-post-error-text"); - toastMessage.innerText = + toastMessage.textContent = (response && response.details) || "Error, please try again later."; bootstrap.Toast.getOrCreateInstance(toast).show(); diff --git a/files/assets/js/markdown.js b/files/assets/js/markdown.js index 29bd2e0aa..990c538af 100644 --- a/files/assets/js/markdown.js +++ b/files/assets/js/markdown.js @@ -269,7 +269,7 @@ function charLimit(form, text) { text.style.color = "#A0AEC0"; } - text.innerText = length + ' / ' + maxLength; + text.textContent = length + ' / ' + maxLength; } function remove_dialog() { diff --git a/files/assets/js/search.js b/files/assets/js/search.js index 641ce5821..9fd92ef75 100644 --- a/files/assets/js/search.js +++ b/files/assets/js/search.js @@ -1,5 +1,5 @@ function addParam(t, bool) { - let text = t.innerText; + let text = t.textContent; if (bool) text = text + ' ' else diff --git a/files/assets/js/userpage_v.js b/files/assets/js/userpage_v.js index b2b522e9c..8a9228c70 100644 --- a/files/assets/js/userpage_v.js +++ b/files/assets/js/userpage_v.js @@ -14,13 +14,13 @@ let TRANSFER_TAX = document.getElementById('tax').innerHTML function updateTax(mobile=false) { let suf = mobile ? "-mobile" : ""; let amount = parseInt(document.getElementById("coin-transfer-amount" + suf).value); - if (amount > 0) document.getElementById("coins-transfer-taxed" + suf).innerText = amount - Math.ceil(amount*TRANSFER_TAX); + if (amount > 0) document.getElementById("coins-transfer-taxed" + suf).textContent = amount - Math.ceil(amount*TRANSFER_TAX); } function updateBux(mobile=false) { let suf = mobile ? "-mobile" : ""; let amount = parseInt(document.getElementById("bux-transfer-amount" + suf).value); - if (amount > 0) document.getElementById("bux-transfer-taxed" + suf).innerText = amount; + if (amount > 0) document.getElementById("bux-transfer-taxed" + suf).textContent = amount; } function transferCoins(t, mobile=false) { @@ -39,9 +39,9 @@ function transferCoins(t, mobile=false) { "reason": document.getElementById(mobile ? "coin-transfer-reason-mobile" : "coin-transfer-reason").value }, () => { - document.getElementById("user-coins-amount").innerText = parseInt(document.getElementById("user-coins-amount").innerText) - amount; - document.getElementById("profile-coins-amount-mobile").innerText = parseInt(document.getElementById("profile-coins-amount-mobile").innerText) + transferred; - document.getElementById("profile-coins-amount").innerText = parseInt(document.getElementById("profile-coins-amount").innerText) + transferred; + document.getElementById("user-coins-amount").textContent = parseInt(document.getElementById("user-coins-amount").textContent) - amount; + document.getElementById("profile-coins-amount-mobile").textContent = parseInt(document.getElementById("profile-coins-amount-mobile").textContent) + transferred; + document.getElementById("profile-coins-amount").textContent = parseInt(document.getElementById("profile-coins-amount").textContent) + transferred; } ); } @@ -60,9 +60,9 @@ function transferBux(t, mobile=false) { "reason": document.getElementById(mobile ? "bux-transfer-reason-mobile" : "bux-transfer-reason").value }, () => { - document.getElementById("user-bux-amount").innerText = parseInt(document.getElementById("user-bux-amount").innerText) - amount; - document.getElementById("profile-bux-amount-mobile").innerText = parseInt(document.getElementById("profile-bux-amount-mobile").innerText) + amount; - document.getElementById("profile-bux-amount").innerText = parseInt(document.getElementById("profile-bux-amount").innerText) + amount; + document.getElementById("user-bux-amount").textContent = parseInt(document.getElementById("user-bux-amount").textContent) - amount; + document.getElementById("profile-bux-amount-mobile").textContent = parseInt(document.getElementById("profile-bux-amount-mobile").textContent) + amount; + document.getElementById("profile-bux-amount").textContent = parseInt(document.getElementById("profile-bux-amount").textContent) + amount; } ); }