From 0e0a8d391babb997e9598d381440a583591e3a13 Mon Sep 17 00:00:00 2001 From: TLSM Date: Sat, 4 Jun 2022 23:58:03 -0400 Subject: [PATCH] Amend 20b136909: string comparison bug. Fixes logic which failed because user_id was a string which I improperly treated as an integer for comparisons. --- files/routes/admin.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/files/routes/admin.py b/files/routes/admin.py index d10bcbe63..5deed1fe2 100644 --- a/files/routes/admin.py +++ b/files/routes/admin.py @@ -1075,11 +1075,12 @@ def unshadowban(user_id, v): @limiter.limit("1/second;30/minute;200/hour;1000/day") @admin_level_required(2) def admin_title_change(user_id, v): - if CARP_ID > 0 and user_id == CARP_ID: - abort(403) user = g.db.query(User).filter_by(id=user_id).one_or_none() + if CARP_ID > 0 and user.id == CARP_ID: + abort(403) + new_name=request.values.get("title").strip()[:256] user.customtitleplain=new_name