From 0bfeabd68277f09fb444f66aad0473a87da9a651 Mon Sep 17 00:00:00 2001
From: Aevann <randomname42029@gmail.com>
Date: Wed, 27 Sep 2023 00:30:03 +0300
Subject: [PATCH] Revert "remove unnecessary response code"

This reverts commit f7e4c77898c2c896d42788c6f71b0826eee953ad.
---
 files/routes/chat.py   | 10 +++++-----
 files/routes/errors.py |  2 +-
 files/routes/static.py |  2 +-
 files/routes/users.py  |  4 ++--
 files/routes/votes.py  |  4 ++--
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/files/routes/chat.py b/files/routes/chat.py
index be8d1209e..c820f8c0a 100644
--- a/files/routes/chat.py
+++ b/files/routes/chat.py
@@ -183,7 +183,7 @@ def speak(data, v):
 
 	typing = []
 
-	return ''
+	return '', 204
 
 def refresh_online():
 	emit("online", [online[request.referrer], muted], room=request.referrer, broadcast=True)
@@ -212,7 +212,7 @@ def connect(v):
 	refresh_online()
 
 	emit('typing', typing[request.referrer], room=request.referrer)
-	return ''
+	return '', 204
 
 @socketio.on('disconnect')
 @auth_required_socketio
@@ -236,7 +236,7 @@ def disconnect(v):
 	else:
 		leave_room(request.referrer)
 
-	return ''
+	return '', 204
 
 @socketio.on('typing')
 @is_not_banned_socketio
@@ -250,7 +250,7 @@ def typing_indicator(data, v):
 		typing[request.referrer].remove(v.username)
 
 	emit('typing', typing[request.referrer], room=request.referrer, broadcast=True)
-	return ''
+	return '', 204
 
 
 @socketio.on('delete')
@@ -266,7 +266,7 @@ def delete(id, v):
 
 	emit('delete', id, room=request.referrer, broadcast=True)
 
-	return ''
+	return '', 204
 
 
 def close_running_threads():
diff --git a/files/routes/errors.py b/files/routes/errors.py
index 29b84023c..f1c6dd4a3 100644
--- a/files/routes/errors.py
+++ b/files/routes/errors.py
@@ -67,4 +67,4 @@ def error_500(e):
 def allow_nsfw():
 	session["over_18_cookies"] = int(time.time()) + 3600
 	redir = request.values.get("redir", "/")
-	return ''
+	return '', 204
diff --git a/files/routes/static.py b/files/routes/static.py
index eadc15a85..98fa1e3f6 100644
--- a/files/routes/static.py
+++ b/files/routes/static.py
@@ -380,7 +380,7 @@ def mobile_app(v):
 @limiter.limit(DEFAULT_RATELIMIT, deduct_when=lambda response: response.status_code < 400)
 def dismiss_mobile_tip():
 	session["tooltip_dismissed"] = int(time.time())
-	return ''
+	return "", 204
 
 @app.get("/transfers/<int:id>")
 @limiter.limit(DEFAULT_RATELIMIT, deduct_when=lambda response: response.status_code < 400)
diff --git a/files/routes/users.py b/files/routes/users.py
index 305dce9a1..1698b122b 100644
--- a/files/routes/users.py
+++ b/files/routes/users.py
@@ -1292,7 +1292,7 @@ def subscribed_posts(v, username):
 @auth_required
 def fp(v, fp):
 	if session.get("GLOBAL"):
-		return ''
+		return '', 204
 
 	v.fp = fp
 	users = g.db.query(User).filter(User.fp == fp, User.id != v.id).all()
@@ -1309,7 +1309,7 @@ def fp(v, fp):
 
 	check_for_alts(v, include_current_session=True)
 	g.db.add(v)
-	return ''
+	return '', 204
 
 @app.post("/toggle_pins/<sub>/<sort>")
 @limiter.limit(DEFAULT_RATELIMIT, deduct_when=lambda response: response.status_code < 400)
diff --git a/files/routes/votes.py b/files/routes/votes.py
index 60220400d..9da62de81 100644
--- a/files/routes/votes.py
+++ b/files/routes/votes.py
@@ -62,7 +62,7 @@ def vote_post_comment(target_id, new, v, cls, vote_cls):
 
 	imlazy = 0
 
-	if existing and existing.vote_type == new: return ''
+	if existing and existing.vote_type == new: return "", 204
 	if existing:
 		if existing.vote_type == 0 and new != 0:
 			imlazy = 1
@@ -178,7 +178,7 @@ def vote_post_comment(target_id, new, v, cls, vote_cls):
 		target.author.pay_account('coins', coin_value)
 		target.author.truescore += coin_delta
 
-	return ''
+	return "", 204
 
 @app.get("/votes/<link>")
 @limiter.limit(DEFAULT_RATELIMIT, deduct_when=lambda response: response.status_code < 400)