Commit Graph

1063 Commits (742a3698ea217b982abc927ad4be68f728c6c2e3)

Author SHA1 Message Date
Aevann1 3356504b78 sneed 2022-07-04 05:50:01 +02:00
Aevann1 72013dcb43 fix 500 error 2022-07-04 03:05:26 +02:00
Aevann1 978c3eb880 fix this https://chapotraphouse.club/post/18459/marseycapywalking-megathread-for-bugs-and-suggestions/2242521?context=8#context 2022-07-04 03:04:33 +02:00
Snakes 9e1a3be278 Fix DMs improperly treating all users as blocked.
The changes to helpers/get.py @ get_user(...) in a6b7fed2fc resulted
in `is_blocking` no longer being present on all User objects retrieved
via `get_user`. This triggered a latent identifier shadow where the
property method `User.is_blocking` on the User model caused checks for
blocks on objects retrieved via `get_user` to always return True.

Notably: when the get_user return value left `is_blocking` unset and
thus implied False, the following expression yielded True due to the
presence of the first-class function at the same identifier:

    hasattr(user, 'is_blocking') and user.is_blocking
2022-07-03 13:55:25 -04:00
Aevann1 ed86ec1c14 more query optimization v3 2022-07-03 13:56:40 +02:00
Aevann1 45437997c8 show log timestamp in local timezone 2022-07-03 10:38:19 +02:00
Aevann1 3245656787 show timestamps in the user timezone 2022-07-03 09:41:25 +02:00
Aevann1 f79fb803ae fix 500 error 2022-07-03 08:16:26 +02:00
Aevann1 1f0f0ef0be messing with joins 2022-07-03 08:12:53 +02:00
Aevann1 6c5b5a5314 add a "subscribed" tab in ur profile page to show posts u subscribed to 2022-07-03 04:43:49 +02:00
Aevann1 a8c4c7bcc5 order child comments by upvotes 2022-07-03 04:10:02 +02:00
Aevann1 386bfa1f3b fix 500 error 2022-07-02 13:02:03 +02:00
Aevann1 bce4c13043 kitchen sink commit, all over the place 2022-07-02 12:44:05 +02:00
Aevann1 5b8b53e312 fix 500 error 2022-07-02 11:47:49 +02:00
Aevann1 3e1ac91b66 fix 500 error 2022-07-02 11:47:35 +02:00
Aevann1 890b21923e remove unnecessary relationships 2022-07-02 08:54:34 +02:00
Aevann1 7db7abc3ab fix 500 error 2022-07-02 08:52:11 +02:00
Aevann1 1a0b2b6813 fix 500 errors 2022-07-02 08:51:19 +02:00
Aevann1 d0d15c319a Poll rework (#312)
* poll rework

* forgot to do joinedload on comments

* Fix logic errors with voting, SQL syntax.

Kitchen sink commit from review of poll-rework changes:
  1. Fix seed-db.sql syntax error.
  2. Fix SQL patch file duplication of *submissions* tables rather
     than one set of submissions and one for comments.
  3. Start makeshift SQL patch folder, since this is a large change
     that contributors may wish to apply to their local instances.
  4. Fix checkbox (non-`exclusive`) polls being unable to be
     unchecked. For consistency with `exclusive` polls, they should.
  5. Fix changing the option of an `exclusive` poll when both
     exclusive and non-exclusive options are present in one comment/
     post causing the non-exclusive options to become unchecked.
     (which, by my reading of SQLAlchemy `Query.one_or_none()`
     really could break quite badly in some cases).

* link relationships with their counterparts

* small modification to poll unchecking

Co-authored-by: TLSM <duolsm@outlook.com>
2022-07-02 08:48:04 +02:00
Aevann1 f56be06eb8 add hole pinning 2022-07-02 01:11:48 +02:00
Aevann1 070945d98a cut down on the number of queries 2022-06-29 09:22:18 +02:00
Aevann1 5661cdb271 Revert "try to cut down on number of db queries"
This reverts commit c674c6a056.
2022-06-29 08:43:20 +02:00
Aevann1 c674c6a056 try to cut down on number of db queries 2022-06-29 08:14:25 +02:00
Aevann1 c341be2866 show posts by users who block you 2022-06-29 05:07:00 +02:00
Aevann1 4fae28a2a2 fix child comment highlighting 2022-06-28 02:41:25 +02:00
Aevann1 ab5078f313 show vote time 2022-06-27 06:10:10 +02:00
Aevann1 52a8a219ae make poorcel-mode device-specific 2022-06-27 05:46:32 +02:00
Aevann1 b1ef8e4c62 add poorcel mode 2022-06-27 04:14:53 +02:00
Aevann1 8b8f99695b make ppl with 200 coins able to bet 2022-06-26 23:40:02 +02:00
Aevann1 e7ce39bd80 fix poll-voting 2022-06-26 22:53:12 +02:00
Aevann1 b450d5bb8c fix sorting by bottom for comments 2022-06-26 08:16:05 +02:00
Aevann1 81243b48dd fix sorting by top/bottom for posts 2022-06-26 08:15:06 +02:00
Aevann1 5e745e38d3 revert the saving and subscription shit 2022-06-26 08:11:38 +02:00
Aevann1 5aad7e09a6 dont query polls on frontpage 2022-06-26 08:10:02 +02:00
Aevann1 4d7e7b629b fix 0ef33b396a 2022-06-26 07:51:02 +02:00
Aevann1 0ef33b396a make checking if a post is subscribed to less retarded 2022-06-26 07:45:49 +02:00
Aevann1 2a8b7bf281 undefer css (1 less query) 2022-06-26 07:39:46 +02:00
Aevann1 e36adb5bf4 reduce query volume, badge edition 2022-06-26 07:11:25 +02:00
Aevann1 ecc22cfc06 fix 2b1e7f6570 2022-06-26 06:57:31 +02:00
Aevann1 2b1e7f6570 make checking if a post/comment is saved less retarded 2022-06-26 06:54:41 +02:00
Aevann1 e34cbeca31 fix 3b8188fd67 2022-06-26 03:25:17 +02:00
Aevann1 3b8188fd67 fixed version of d83d47e280 2022-06-26 03:22:05 +02:00
Aevann1 a1b137447e Revert "reduce query volume #1"
This reverts commit d83d47e280.
2022-06-26 03:12:31 +02:00
Aevann1 cff34fb3a4 reducing query volume, #2 2022-06-26 03:11:02 +02:00
Aevann1 cd4b3b7d3b Merge branch 'frost' of https://github.com/Aevann1/Drama into frost 2022-06-26 02:50:49 +02:00
Aevann1 d83d47e280 reduce query volume #1 2022-06-26 02:50:47 +02:00
Snakes 7b38be0101 Reduce query volume in user.user_awards.
The User model class method user_awards previously made one query
per type of award. This has been replaced with a new query that
retrieves all owned award quantities at once using GROUP BY.
2022-06-25 20:22:56 -04:00
Aevann1 bc7185b5af order awards by the time they were awarded 2022-06-25 22:33:51 +02:00
Aevann1 ffd0d9ed31 show duration on ban icon tooltip 2022-06-25 02:11:00 +02:00
Snakes 47159f338d Fix exception when serializing comments JSON.
The JSON API endpoints that return comments, most notably `/comments`
returned 500s and created a stack trace with:

  TypeError: Object of type method is not JSON serializable

Further debugging revealed this was because json.encoder was being
given a <bound method lazy.<locals>.wrapper of <Comment(id=123)>> to
serialize.

The introduction of the bug was traced to 8ecb4582d0 where it was
discovered that the (seemingly inadvertent) removal of the @property
decorator on classes/comment.py:parent_fullname was the root cause.

In light of the fact that parent_fullname was unrelated to the changes
intended in 8ecb4582d0 and that no other refactoring around
parent_fullname was done, it was restored to being a @property rather
than its callers modified to invoke it as a method.
2022-06-24 15:26:18 -04:00