From d9e7f0100ad14121b43b89d54b80fb2345d8d83e Mon Sep 17 00:00:00 2001 From: Nutomic Date: Wed, 1 Mar 2023 03:36:57 +0100 Subject: [PATCH] Dont upsert Instance row every apub fetch (#2771) This is not necessary because the domain cant change, so we only need to insert if no row exists for this domain. Also fetch instance actor when parsing person, not only community Co-authored-by: Dessalines --- crates/api/src/lib.rs | 4 +- .../src/collections/community_moderators.rs | 2 +- crates/apub/src/objects/community.rs | 8 +-- crates/apub/src/objects/instance.rs | 29 +++++++--- crates/apub/src/objects/person.rs | 13 +---- .../src/aggregates/comment_aggregates.rs | 4 +- .../src/aggregates/community_aggregates.rs | 4 +- .../src/aggregates/person_aggregates.rs | 4 +- .../src/aggregates/post_aggregates.rs | 4 +- .../src/aggregates/site_aggregates.rs | 4 +- crates/db_schema/src/impls/activity.rs | 4 +- crates/db_schema/src/impls/actor_language.rs | 4 +- crates/db_schema/src/impls/comment.rs | 4 +- crates/db_schema/src/impls/comment_reply.rs | 4 +- crates/db_schema/src/impls/community.rs | 4 +- .../src/impls/federation_allowlist.rs | 2 +- .../src/impls/federation_blocklist.rs | 2 +- crates/db_schema/src/impls/instance.rs | 58 +++++++++++-------- crates/db_schema/src/impls/moderator.rs | 4 +- .../src/impls/password_reset_request.rs | 4 +- crates/db_schema/src/impls/person.rs | 8 ++- crates/db_schema/src/impls/person_mention.rs | 4 +- crates/db_schema/src/impls/post.rs | 4 +- crates/db_schema/src/impls/private_message.rs | 4 +- crates/db_views/src/comment_report_view.rs | 4 +- crates/db_views/src/comment_view.rs | 4 +- crates/db_views/src/post_report_view.rs | 4 +- crates/db_views/src/post_view.rs | 4 +- .../src/private_message_report_view.rs | 4 +- .../src/registration_application_view.rs | 4 +- src/code_migrations.rs | 2 +- 31 files changed, 135 insertions(+), 77 deletions(-) diff --git a/crates/api/src/lib.rs b/crates/api/src/lib.rs index 217002ab3..5c23ec345 100644 --- a/crates/api/src/lib.rs +++ b/crates/api/src/lib.rs @@ -78,7 +78,9 @@ mod tests { let secret = Secret::init(pool).await.unwrap(); let settings = &SETTINGS.to_owned(); - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("Gerry9812".into()) diff --git a/crates/apub/src/collections/community_moderators.rs b/crates/apub/src/collections/community_moderators.rs index 9616ddb30..5c05258d1 100644 --- a/crates/apub/src/collections/community_moderators.rs +++ b/crates/apub/src/collections/community_moderators.rs @@ -156,7 +156,7 @@ mod tests { let community = parse_lemmy_community(&context).await; let community_id = community.id; - let inserted_instance = Instance::create(context.pool(), "my_domain.tld") + let inserted_instance = Instance::read_or_create(context.pool(), "my_domain.tld".to_string()) .await .unwrap(); diff --git a/crates/apub/src/objects/community.rs b/crates/apub/src/objects/community.rs index 9f8cfae60..7a1583ca0 100644 --- a/crates/apub/src/objects/community.rs +++ b/crates/apub/src/objects/community.rs @@ -26,7 +26,6 @@ use lemmy_db_schema::{ source::{ actor_language::CommunityLanguage, community::{Community, CommunityUpdateForm}, - instance::Instance, }, traits::{ApubActor, Crud}, }; @@ -136,10 +135,9 @@ impl ApubObject for ApubCommunity { context: &LemmyContext, request_counter: &mut i32, ) -> Result { - let apub_id = group.id.inner().clone(); - let instance = Instance::create_from_actor_id(context.pool(), &apub_id).await?; + let instance_id = fetch_instance_actor_for_object(&group.id, context, request_counter).await?; - let form = Group::into_insert_form(group.clone(), instance.id); + let form = Group::into_insert_form(group.clone(), instance_id); let languages = LanguageTag::to_language_id_multiple(group.language, context.pool()).await?; let community = Community::create(context.pool(), &form).await?; @@ -165,8 +163,6 @@ impl ApubObject for ApubCommunity { .ok(); } - fetch_instance_actor_for_object(community.actor_id(), context, request_counter).await; - Ok(community) } } diff --git a/crates/apub/src/objects/instance.rs b/crates/apub/src/objects/instance.rs index fff79463b..8fa3976ac 100644 --- a/crates/apub/src/objects/instance.rs +++ b/crates/apub/src/objects/instance.rs @@ -20,6 +20,7 @@ use activitystreams_kinds::actor::ApplicationType; use chrono::NaiveDateTime; use lemmy_api_common::{context::LemmyContext, utils::local_site_opt_to_slur_regex}; use lemmy_db_schema::{ + newtypes::InstanceId, source::{ actor_language::SiteLanguage, instance::Instance as DbInstance, @@ -134,8 +135,8 @@ impl ApubObject for ApubSite { data: &Self::DataType, _request_counter: &mut i32, ) -> Result { - let apub_id = apub.id.inner().clone(); - let instance = DbInstance::create_from_actor_id(data.pool(), &apub_id).await?; + let domain = apub.id.inner().domain().expect("group id has domain"); + let instance = DbInstance::read_or_create(data.pool(), domain.to_string()).await?; let site_form = SiteInsertForm { name: apub.name.clone(), @@ -178,19 +179,29 @@ impl Actor for ApubSite { } } -/// try to fetch the instance actor (to make things like instance rules available) -pub(in crate::objects) async fn fetch_instance_actor_for_object( - object_id: Url, +/// Try to fetch the instance actor (to make things like instance rules available). +pub(in crate::objects) async fn fetch_instance_actor_for_object + Clone>( + object_id: &T, context: &LemmyContext, request_counter: &mut i32, -) { - // try to fetch the instance actor (to make things like instance rules available) +) -> Result { + let object_id: Url = object_id.clone().into(); let instance_id = Site::instance_actor_id_from_url(object_id); let site = ObjectId::::new(instance_id.clone()) .dereference(context, local_instance(context).await, request_counter) .await; - if let Err(e) = site { - debug!("Failed to dereference site for {}: {}", instance_id, e); + match site { + Ok(s) => Ok(s.instance_id), + Err(e) => { + // Failed to fetch instance actor, its probably not a lemmy instance + debug!("Failed to dereference site for {}: {}", &instance_id, e); + let domain = instance_id.domain().expect("has domain"); + Ok( + DbInstance::read_or_create(context.pool(), domain.to_string()) + .await? + .id, + ) + } } } diff --git a/crates/apub/src/objects/person.rs b/crates/apub/src/objects/person.rs index 1b7e86d90..55bfcd29a 100644 --- a/crates/apub/src/objects/person.rs +++ b/crates/apub/src/objects/person.rs @@ -23,10 +23,7 @@ use lemmy_api_common::{ utils::{generate_outbox_url, local_site_opt_to_slur_regex}, }; use lemmy_db_schema::{ - source::{ - instance::Instance, - person::{Person as DbPerson, PersonInsertForm, PersonUpdateForm}, - }, + source::person::{Person as DbPerson, PersonInsertForm, PersonUpdateForm}, traits::{ApubActor, Crud}, utils::naive_now, }; @@ -149,8 +146,7 @@ impl ApubObject for ApubPerson { context: &LemmyContext, request_counter: &mut i32, ) -> Result { - let apub_id = person.id.inner().clone(); - let instance = Instance::create_from_actor_id(context.pool(), &apub_id).await?; + let instance_id = fetch_instance_actor_for_object(&person.id, context, request_counter).await?; let person_form = PersonInsertForm { name: person.preferred_username, @@ -173,13 +169,10 @@ impl ApubObject for ApubPerson { inbox_url: Some(person.inbox.into()), shared_inbox_url: person.endpoints.map(|e| e.shared_inbox.into()), matrix_user_id: person.matrix_user_id, - instance_id: instance.id, + instance_id, }; let person = DbPerson::create(context.pool(), &person_form).await?; - let actor_id = person.actor_id.clone().into(); - fetch_instance_actor_for_object(actor_id, context, request_counter).await; - Ok(person.into()) } } diff --git a/crates/db_schema/src/aggregates/comment_aggregates.rs b/crates/db_schema/src/aggregates/comment_aggregates.rs index 56528a5fe..f56fd8cbe 100644 --- a/crates/db_schema/src/aggregates/comment_aggregates.rs +++ b/crates/db_schema/src/aggregates/comment_aggregates.rs @@ -38,7 +38,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("thommy_comment_agg".into()) diff --git a/crates/db_schema/src/aggregates/community_aggregates.rs b/crates/db_schema/src/aggregates/community_aggregates.rs index 96dbb8fb4..2c2eaa781 100644 --- a/crates/db_schema/src/aggregates/community_aggregates.rs +++ b/crates/db_schema/src/aggregates/community_aggregates.rs @@ -38,7 +38,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("thommy_community_agg".into()) diff --git a/crates/db_schema/src/aggregates/person_aggregates.rs b/crates/db_schema/src/aggregates/person_aggregates.rs index b8e1887a1..6f8045908 100644 --- a/crates/db_schema/src/aggregates/person_aggregates.rs +++ b/crates/db_schema/src/aggregates/person_aggregates.rs @@ -38,7 +38,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("thommy_user_agg".into()) diff --git a/crates/db_schema/src/aggregates/post_aggregates.rs b/crates/db_schema/src/aggregates/post_aggregates.rs index dca5fb826..848f2014b 100644 --- a/crates/db_schema/src/aggregates/post_aggregates.rs +++ b/crates/db_schema/src/aggregates/post_aggregates.rs @@ -38,7 +38,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("thommy_community_agg".into()) diff --git a/crates/db_schema/src/aggregates/site_aggregates.rs b/crates/db_schema/src/aggregates/site_aggregates.rs index 8b4ccb374..719beb8f7 100644 --- a/crates/db_schema/src/aggregates/site_aggregates.rs +++ b/crates/db_schema/src/aggregates/site_aggregates.rs @@ -35,7 +35,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("thommy_site_agg".into()) diff --git a/crates/db_schema/src/impls/activity.rs b/crates/db_schema/src/impls/activity.rs index a3137f355..bdf0f1dc2 100644 --- a/crates/db_schema/src/impls/activity.rs +++ b/crates/db_schema/src/impls/activity.rs @@ -109,7 +109,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let creator_form = PersonInsertForm::builder() .name("activity_creator_ pm".into()) diff --git a/crates/db_schema/src/impls/actor_language.rs b/crates/db_schema/src/impls/actor_language.rs index d515d44f0..bf3e7ac98 100644 --- a/crates/db_schema/src/impls/actor_language.rs +++ b/crates/db_schema/src/impls/actor_language.rs @@ -404,7 +404,9 @@ mod tests { } async fn create_test_site(pool: &DbPool) -> (Site, Instance) { - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let site_form = SiteInsertForm::builder() .name("test site".to_string()) diff --git a/crates/db_schema/src/impls/comment.rs b/crates/db_schema/src/impls/comment.rs index 2dfae6dd2..2a9eeafed 100644 --- a/crates/db_schema/src/impls/comment.rs +++ b/crates/db_schema/src/impls/comment.rs @@ -277,7 +277,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("terry".into()) diff --git a/crates/db_schema/src/impls/comment_reply.rs b/crates/db_schema/src/impls/comment_reply.rs index 73ecd3589..2489c982f 100644 --- a/crates/db_schema/src/impls/comment_reply.rs +++ b/crates/db_schema/src/impls/comment_reply.rs @@ -94,7 +94,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("terrylake".into()) diff --git a/crates/db_schema/src/impls/community.rs b/crates/db_schema/src/impls/community.rs index d1a4f2b6c..f341b5ed9 100644 --- a/crates/db_schema/src/impls/community.rs +++ b/crates/db_schema/src/impls/community.rs @@ -423,7 +423,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("bobbee".into()) diff --git a/crates/db_schema/src/impls/federation_allowlist.rs b/crates/db_schema/src/impls/federation_allowlist.rs index 79efecc9a..c71ffd1cf 100644 --- a/crates/db_schema/src/impls/federation_allowlist.rs +++ b/crates/db_schema/src/impls/federation_allowlist.rs @@ -21,7 +21,7 @@ impl FederationAllowList { for domain in list { // Upsert all of these as instances - let instance = Instance::create_conn(conn, &domain).await?; + let instance = Instance::read_or_create_with_conn(conn, domain).await?; let form = FederationAllowListForm { instance_id: instance.id, diff --git a/crates/db_schema/src/impls/federation_blocklist.rs b/crates/db_schema/src/impls/federation_blocklist.rs index 41f0ebe7c..917bf57a3 100644 --- a/crates/db_schema/src/impls/federation_blocklist.rs +++ b/crates/db_schema/src/impls/federation_blocklist.rs @@ -21,7 +21,7 @@ impl FederationBlockList { for domain in list { // Upsert all of these as instances - let instance = Instance::create_conn(conn, &domain).await?; + let instance = Instance::read_or_create_with_conn(conn, domain).await?; let form = FederationBlockListForm { instance_id: instance.id, diff --git a/crates/db_schema/src/impls/instance.rs b/crates/db_schema/src/impls/instance.rs index 473ca007e..e5a8caba3 100644 --- a/crates/db_schema/src/impls/instance.rs +++ b/crates/db_schema/src/impls/instance.rs @@ -6,36 +6,45 @@ use crate::{ }; use diesel::{dsl::insert_into, result::Error, ExpressionMethods, QueryDsl}; use diesel_async::{AsyncPgConnection, RunQueryDsl}; -use url::Url; impl Instance { - async fn create_from_form_conn( + pub(crate) async fn read_or_create_with_conn( conn: &mut AsyncPgConnection, - form: &InstanceForm, + domain_: String, ) -> Result { - // Do upsert on domain name conflict - insert_into(instance::table) - .values(form) - .on_conflict(instance::domain) - .do_update() - .set(form) - .get_result::(conn) - .await + use crate::schema::instance::domain; + // First try to read the instance row and return directly if found + let instance = instance::table + .filter(domain.eq(&domain_)) + .first::(conn) + .await; + match instance { + Ok(i) => Ok(i), + Err(diesel::NotFound) => { + // Instance not in database yet, insert it + let form = InstanceForm::builder() + .domain(domain_) + .updated(Some(naive_now())) + .build(); + insert_into(instance::table) + .values(&form) + // Necessary because this method may be called concurrently for the same domain. This + // could be handled with a transaction, but nested transactions arent allowed + .on_conflict(instance::domain) + .do_update() + .set(&form) + .get_result::(conn) + .await + } + e => e, + } } - pub async fn create(pool: &DbPool, domain: &str) -> Result { + + /// Attempt to read Instance column for the given domain. If it doesnt exist, insert a new one. + /// There is no need for update as the domain of an existing instance cant change. + pub async fn read_or_create(pool: &DbPool, domain: String) -> Result { let conn = &mut get_conn(pool).await?; - Self::create_conn(conn, domain).await - } - pub async fn create_from_actor_id(pool: &DbPool, actor_id: &Url) -> Result { - let domain = actor_id.host_str().expect("actor id missing a domain"); - Self::create(pool, domain).await - } - pub async fn create_conn(conn: &mut AsyncPgConnection, domain: &str) -> Result { - let form = InstanceForm::builder() - .domain(domain.to_string()) - .updated(Some(naive_now())) - .build(); - Self::create_from_form_conn(conn, &form).await + Self::read_or_create_with_conn(conn, domain).await } pub async fn delete(pool: &DbPool, instance_id: InstanceId) -> Result { let conn = &mut get_conn(pool).await?; @@ -43,6 +52,7 @@ impl Instance { .execute(conn) .await } + #[cfg(test)] pub async fn delete_all(pool: &DbPool) -> Result { let conn = &mut get_conn(pool).await?; diesel::delete(instance::table).execute(conn).await diff --git a/crates/db_schema/src/impls/moderator.rs b/crates/db_schema/src/impls/moderator.rs index 23be96146..7540e4871 100644 --- a/crates/db_schema/src/impls/moderator.rs +++ b/crates/db_schema/src/impls/moderator.rs @@ -549,7 +549,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_mod = PersonInsertForm::builder() .name("the mod".into()) diff --git a/crates/db_schema/src/impls/password_reset_request.rs b/crates/db_schema/src/impls/password_reset_request.rs index 4aa5599a0..ebe8a00ec 100644 --- a/crates/db_schema/src/impls/password_reset_request.rs +++ b/crates/db_schema/src/impls/password_reset_request.rs @@ -103,7 +103,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("thommy prw".into()) diff --git a/crates/db_schema/src/impls/person.rs b/crates/db_schema/src/impls/person.rs index fa7d2530f..13be58433 100644 --- a/crates/db_schema/src/impls/person.rs +++ b/crates/db_schema/src/impls/person.rs @@ -285,7 +285,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("holly".into()) @@ -342,7 +344,9 @@ mod tests { #[serial] async fn follow() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let person_form_1 = PersonInsertForm::builder() .name("erich".into()) diff --git a/crates/db_schema/src/impls/person_mention.rs b/crates/db_schema/src/impls/person_mention.rs index cf7e9e2d3..559340e78 100644 --- a/crates/db_schema/src/impls/person_mention.rs +++ b/crates/db_schema/src/impls/person_mention.rs @@ -98,7 +98,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("terrylake".into()) diff --git a/crates/db_schema/src/impls/post.rs b/crates/db_schema/src/impls/post.rs index 9f5c64389..8c5ffa8ad 100644 --- a/crates/db_schema/src/impls/post.rs +++ b/crates/db_schema/src/impls/post.rs @@ -360,7 +360,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("jim".into()) diff --git a/crates/db_schema/src/impls/private_message.rs b/crates/db_schema/src/impls/private_message.rs index b20fee89c..a30ac20e5 100644 --- a/crates/db_schema/src/impls/private_message.rs +++ b/crates/db_schema/src/impls/private_message.rs @@ -111,7 +111,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let creator_form = PersonInsertForm::builder() .name("creator_pm".into()) diff --git a/crates/db_views/src/comment_report_view.rs b/crates/db_views/src/comment_report_view.rs index f4e94cc07..f9d2077fb 100644 --- a/crates/db_views/src/comment_report_view.rs +++ b/crates/db_views/src/comment_report_view.rs @@ -335,7 +335,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("timmy_crv".into()) diff --git a/crates/db_views/src/comment_view.rs b/crates/db_views/src/comment_view.rs index c1b38e3af..4fb950a52 100644 --- a/crates/db_views/src/comment_view.rs +++ b/crates/db_views/src/comment_view.rs @@ -450,7 +450,9 @@ mod tests { } async fn init_data(pool: &DbPool) -> Data { - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("timmy".into()) diff --git a/crates/db_views/src/post_report_view.rs b/crates/db_views/src/post_report_view.rs index 523a19feb..e2661d6d6 100644 --- a/crates/db_views/src/post_report_view.rs +++ b/crates/db_views/src/post_report_view.rs @@ -311,7 +311,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person = PersonInsertForm::builder() .name("timmy_prv".into()) diff --git a/crates/db_views/src/post_view.rs b/crates/db_views/src/post_view.rs index a7207aa9a..1427d9483 100644 --- a/crates/db_views/src/post_view.rs +++ b/crates/db_views/src/post_view.rs @@ -498,7 +498,9 @@ mod tests { } async fn init_data(pool: &DbPool) -> Data { - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let person_name = "tegan".to_string(); diff --git a/crates/db_views/src/private_message_report_view.rs b/crates/db_views/src/private_message_report_view.rs index 29cd5d0e2..647256ade 100644 --- a/crates/db_views/src/private_message_report_view.rs +++ b/crates/db_views/src/private_message_report_view.rs @@ -169,7 +169,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let new_person_1 = PersonInsertForm::builder() .name("timmy_mrv".into()) diff --git a/crates/db_views/src/registration_application_view.rs b/crates/db_views/src/registration_application_view.rs index 22f62a881..0b5fa05e1 100644 --- a/crates/db_views/src/registration_application_view.rs +++ b/crates/db_views/src/registration_application_view.rs @@ -186,7 +186,9 @@ mod tests { async fn test_crud() { let pool = &build_db_pool_for_tests().await; - let inserted_instance = Instance::create(pool, "my_domain.tld").await.unwrap(); + let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) + .await + .unwrap(); let timmy_person_form = PersonInsertForm::builder() .name("timmy_rav".into()) diff --git a/src/code_migrations.rs b/src/code_migrations.rs index 5151611bd..07c29beac 100644 --- a/src/code_migrations.rs +++ b/src/code_migrations.rs @@ -429,7 +429,7 @@ async fn initialize_local_site_2022_10_10( .expect("must have domain"); // Upsert this to the instance table - let instance = Instance::create(pool, &domain).await?; + let instance = Instance::read_or_create(pool, domain).await?; if let Some(setup) = &settings.setup { let person_keypair = generate_actor_keypair()?;