gsathecat
/
lemmy
mirror of https://github.com/LemmyNet/lemmy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1188 from LemmyNet/fix_blocked_creator_outbox 

Fixed an issue with blocked post creators in outbox.
pull/1201/head
Nutomic 2020-10-12 10:30:48 +00:00 committed by GitHub
parent b19ac26325 cb4a3a03a2
commit 70f7dd876f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lemmy_apub/src/activity_queue.rs
View File

@ -189,10 +189,6 @@ where
return Ok(()); return Ok(());
} }
for to_url in &to {
check_is_apub_id_valid(&to_url)?;
}
let activity = activity.into_any_base()?; let activity = activity.into_any_base()?;
let serialised_activity = serde_json::to_string(&activity)?; let serialised_activity = serde_json::to_string(&activity)?;

8
lemmy_apub/src/fetcher.rs
View File

@ -338,7 +338,13 @@ async fn fetch_remote_community(
} }
for o in outbox_items { for o in outbox_items {
let page = PageExt::from_any_base(o)?.context(location_info!())?; let page = PageExt::from_any_base(o)?.context(location_info!())?;
let post = PostForm::from_apub(&page, context, None).await?;
// The post creator may be from a blocked instance,
// if it errors, then continue
let post = match PostForm::from_apub(&page, context, None).await {
Ok(post) => post,
Err(_) => continue,
};
let post_ap_id = post.ap_id.as_ref().context(location_info!())?.clone(); let post_ap_id = post.ap_id.as_ref().context(location_info!())?.clone();
// Check whether the post already exists in the local db // Check whether the post already exists in the local db
let existing = blocking(context.pool(), move |conn| { let existing = blocking(context.pool(), move |conn| {