gerudo
/
rDrama
forked from rDrama/rDrama
1
0
Fork 0
Code Pull Requests Activity
15,207 Commits
1 Branch
0 Tags
1.8 GiB
Commit Graph

1126 Commits (039991dd4330681803ffa62d8117d8a85ddcbff4)

Author SHA1 Message Date
geese 02928305ed aaa 2022-05-04 21:29:59 -04:00
TLSM 8eb86b965c Partially revert self-upvote UI bug fix. (#239) 
Turns out the snippet in templates/comments.html was necessary to
get proper behavior in notifications.

Might come back to debug this later, but people use notifications more
than they deal with edge case self-upvotes, so reverting for now.

The changes to prevent coin fuckery with self-upvoting appear to work
correctly in the wild, so leaving those in place.
 2022-05-02 21:42:28 +02:00
TLSM d1e2926ca3 Fix comment self-upvote removal UI bug. (#236) 
Fixes minor UI bug when removing self-upvote on a comment. Previous
behavior, starting from a new comment:
    - Initial state: score 1 from self-upvote, upvote button shows
      highlighted as `color: var(--primary)`.
    - Click on upvote button to remove self-upvote → button
      unhighlights, score displays as 0.
    - [reload page]
    - Score displays as 0, but button is highlighted.
    - Click on upvote button → button unhighlights, score displays
      as -1. [If you reload the page now, state is score 0 &
      highlighted; no change in serverside votes.]
    - Click on upvote again → button highlights, score displays as 0.
    - [reload page]
    - Score displays as 1, button is highlighted.
Direct cause is `templates/comments.html @ L115-117`. I checked
`api_comment`, though, and it adds a vote on new comments, and that
state change propagates to the template's parameters before it renders,
so I believe the only time this triggers is specifically when a user
has removed their self-upvote. Bug is fixed when testing with L115-117
removed. Is there some other edge case it was meant to solve?

Secondary bugfix: Removing a self-upvote _costs_ you a coin & a
truescore point. I think this is one of the few ways to get negative
dramacoin. I chose to fix it by having self-votes and self-unvotes not
change coins/truecoins. The alternative of having new comments & posts
give the user +1 coin/truecoin would modify site behavior, and you'd
retroactively owe some powerusers thousands of DC & truescore.
 2022-05-02 20:12:28 +02:00
Aevann1 bc2a20cd4b sfd 2022-05-01 23:44:38 +02:00
Aevann1 139a01998b ti 2022-04-25 23:41:46 +02:00
Aevann1 89b49f9337 sdf 2022-04-24 22:52:10 +02:00
Aevann1 c447af6f50 fdssfd 2022-04-22 22:02:47 +02:00
Aevann1 8d268268f1 fds 2022-04-18 19:20:10 +02:00
Aevann1 6c662e351a fds 2022-04-16 21:14:11 +02:00
Aevann1 777baa68eb fds 2022-04-16 17:50:07 +02:00
Aevann1 99cb01d9fc fdsfds 2022-04-15 18:28:08 +02:00
bAWario 8c25a48d0c Glowiefied Checkmark (#226) 
Co-authored-by: Captain <Captain@PC>
 2022-04-14 00:23:46 +02:00
Aevann1 7f865fb4e6 fd 2022-04-13 03:12:38 +02:00
Aevann1 a4c5e2ac96 sfd 2022-04-13 02:10:48 +02:00
Aevann1 e9e9a72921 fds 2022-04-10 20:06:36 +02:00
Aevann1 aa388dabc4 fsd 2022-04-10 19:46:24 +02:00
Aevann1 3b513d0841 gfd 2022-04-10 01:41:36 +02:00
Aevann1 4a4f402c0d g 2022-04-09 20:26:10 +02:00
Aevann1 1f0d46ba66 fds 2022-04-09 20:09:33 +02:00
Aevann1 94658d1edc g 2022-04-09 20:01:36 +02:00
Aevann1 3f94aaa3cf fds 2022-04-09 19:51:37 +02:00
Aevann1 4a4591876e gf 2022-04-09 19:32:55 +02:00
Aevann1 6db737ba03 ds 2022-04-09 18:42:23 +02:00
Aevann1 6993d28e18 hgf 2022-04-07 02:21:38 +02:00
Aevann1 b45de251f5 gdffds 2022-04-07 02:08:17 +02:00
Aevann1 1c7c40b5ca fsd 2022-04-07 01:03:18 +02:00
Aevann1 d495b961d8 fg 2022-04-06 23:01:32 +02:00
Aevann1 b841e7ae12 fds 2022-04-06 21:33:42 +02:00
Aevann1 30c426f0bd gd 2022-04-05 21:51:10 +02:00
Aevann1 82a21c0a5e sfd 2022-04-05 21:48:46 +02:00
Aevann1 83f222b04e fds 2022-04-05 21:47:48 +02:00
Aevann1 99b35847e4 dfs 2022-04-05 20:06:24 +02:00
Aevann1 835a7ecc55 fds 2022-04-05 19:27:13 +02:00
Aevann1 f2ac1847e3 fds 2022-04-05 18:02:24 +02:00
Aevann1 eca7f466df fsd 2022-04-05 17:04:15 +02:00
Aevann1 c2db52737b sfd 2022-04-05 15:55:32 +02:00
Aevann1 35affa19cd fds 2022-04-05 15:26:53 +02:00
Aevann1 ea107e9966 fsd 2022-04-04 02:42:20 +02:00
Aevann1 7a8108e106 fsd 2022-04-03 22:16:54 +02:00
Aevann1 4c44c2ce92 fds 2022-04-03 17:47:53 +02:00
Aevann1 ae82ada424 fsd 2022-04-02 18:54:27 +02:00
Aevann1 5e48932f08 sdf 2022-04-02 17:26:13 +02:00
Aevann1 d5f64847ac gd 2022-03-31 21:34:04 +02:00
Aevann1 b538d2a24c gdfg 2022-03-31 18:28:53 +02:00
Aevann1 b02b27ce4f fds 2022-03-31 17:00:57 +02:00
Aevann1 1042072ad8 fsd 2022-03-31 16:25:49 +02:00
Aevann1 3a3157def3 df 2022-03-29 19:32:36 +02:00
Aevann1 37d5003af4 bbbbbbbbbbbbb 2022-03-27 15:39:21 +02:00
Aevann1 b74c8711d7 fd 2022-03-26 00:30:15 +02:00
Aevann1 eec1738d01 what a mess 2022-03-24 21:44:12 +02:00