Commit Graph

12 Commits (d2df12fccd6e8a2e750c004c57e9cfe297b5238c)

Author SHA1 Message Date
Cosimo Lupo 083b7fcad7 colrv1_postproc.py: handle missing regional indicators in noflags font
don't bother to do textwrap.dedent, as whitespace doesn't matter in FEA code
2022-02-03 19:13:48 +00:00
Cosimo Lupo 631766222f empty subdivision flag (1F3F4+E007F) should be mapped to uknown flag, not the black flag
The substitution BLACK_FLAG + CANCEL_TAG => UNKNOWN_FLAG is alrady handled by the _add_fallback_subs_for_unknown_flags method, added in the previous commit.
There's no BLACK_FLAG + CANCEL_TAG => BLACK_FLAG substituion in the current NotoColorEmoji.ttf CBDT font.
In fact, it makes much more sense that all unsupported subdivision flag sequences, i.e. BLACK_FLAG + (zero or more non-cancel tags) + CANCEL_TAG, are all displayed with the unknown flag. No reason to special case BLACK_FLAG + CANCEL_TAG.
I'm not sure where the conclusion about the BLACK_FLAG + CANCEL_TAG => BLACK_FLAG came from (got to ask Rod).
2022-02-03 12:28:16 +00:00
Cosimo Lupo f8ec04e4a3 colrv1_postproc: add GSUB lookups replacing unsupported flags with the 'unknown flag'
Any invalid/unsupported emoji flag sequence (whether using regional indicators or subdivision tags) gets replaced by the 'unknown flag' (PUA 0xFE28B), a flag with a blue question mark in the middle.

The logic is mutated from the GSUB table of NotoColorEmoji.tmpl.ttx. We build these extra lookups using feaLib on an temporary empty font (that matches the glyph order of our destination CORLv1 font), then update our font's GSUB with them.
The PUA for the unknown flag is then removed from the cmap, as it's no longer needed. It's also deleted from the CBDT NotoColorEmoji (see emoji_builder.py).
2022-02-03 12:15:46 +00:00
Rod S 16f5f57a79 Rebuilt w/soft light 2022-01-28 21:32:55 -08:00
Cosimo Lupo b83718269e colrv1_postproc: add vhea and vmtx to colrv1 font
copy values from CBDT font, adapt to the different UPEM (CBDT has 2048, COLRv1 has 1024, nanoemoji's default)
Maybe we shold just make the UPEM the same for both?
2022-01-26 16:47:00 +00:00
Cosimo Lupo 5d4f4d6b38 run black on colrv1_postproc.py script to fix indentation 2022-01-26 16:09:18 +00:00
Cosimo Lupo 5a04ef08ee call add_soft_light_to_flags from colrv1_postproc.py script 2022-01-24 18:07:11 +00:00
Rod S a17b1b474b Tweaks to make fontchain_lint happier 2022-01-06 21:54:41 -08:00
Rod S a8f13094d0 Add non-regional flags 2022-01-06 20:28:57 -08:00
Rod S 9d0db6366a One more map to space 2022-01-05 21:14:23 -08:00
Rod S 48aa43748d Exploratory mapping of things to space to match observed shaping in CBDT 2021-12-29 19:08:03 -08:00
Rod S d0bcf99532 Fixmore fontchain_lint issues 2021-12-23 17:44:08 -08:00