forked from rDrama/rDrama
1
0
Fork 0
rDrama/files
Snakes 616634158c
Narrow approved_embed_hosts for security.
Probably will break some peoples' profilecss and irritate the
newsposters, but in light of recent live proven exploits to disclose
user IP & username pairs to remote servers, the broad list of embed
hosts was unsustainable and impossible to prove safe.

We extend is_safe_url to allow whitelisting subdomains, specifically
to solve the s.lain.la open redirect exploit. Also, open media proxies
like external-content.duckduckgo.com were concerning enough, despite
likely being safe, to warrant removal. Anything infrequently used and
difficult to review, or has a reasonable alternative, was also removed.

In general: we want people to be rehosting, and if we want to allow
more external content, we need to run a media proxy. The central issue
is that any user-configurable 302 is a potential disclosure risk, and
Lord knows how many ways there were to get <arbitrarynewssite>.com to
do so. Maybe zero, but the problem is we just don't know.
2022-12-05 18:57:35 -05:00
..
assets sneed 2022-12-05 14:22:33 +00:00
classes allow JL3 to edit rules (#39) 2022-12-05 05:22:08 +00:00
events Revert "blizzard submodule" 2022-11-30 16:10:20 -05:00
helpers Narrow approved_embed_hosts for security. 2022-12-05 18:57:35 -05:00
routes fix pin awards 2022-12-05 18:01:13 +02:00
templates fix margins 2022-12-05 17:23:41 +02:00
__init__.py Add trailing final newlines to source files. 2022-09-29 01:43:29 -04:00
__main__.py ratelimits: turn off autocheck so we can init 2022-11-29 19:29:06 -06:00
cli.py cli.py: fix startup operations using wrong WD. 2022-09-19 23:26:43 -04:00