From 5c80f0017f4f7b7768ef4ff6aa338308abeb7c4e Mon Sep 17 00:00:00 2001
From: Aevann <randomname42029@gmail.com>
Date: Mon, 2 Oct 2023 09:06:29 +0300
Subject: [PATCH] no more href="#"

---
 files/assets/js/emoji_modal.js         | 4 ++--
 files/templates/modals/emoji.html      | 2 +-
 files/templates/settings/personal.html | 8 ++++----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/files/assets/js/emoji_modal.js b/files/assets/js/emoji_modal.js
index bb261a8a0..09277bdcb 100644
--- a/files/assets/js/emoji_modal.js
+++ b/files/assets/js/emoji_modal.js
@@ -221,8 +221,8 @@ function fetchEmojis() {
 				let classSelectorDOM = document.createElement("li");
 				classSelectorDOM.classList.add("nav-item");
 
-				let classSelectorLinkDOM = document.createElement("a");
-				classSelectorLinkDOM.href = "#";
+				let classSelectorLinkDOM = document.createElement("button");
+				classSelectorLinkDOM.type = "button";
 				classSelectorLinkDOM.classList.add("nav-link", "emojitab");
 				classSelectorLinkDOM.dataset.bsToggle = "tab";
 				classSelectorLinkDOM.dataset.className = className;
diff --git a/files/templates/modals/emoji.html b/files/templates/modals/emoji.html
index 9ae836411..266bfb47b 100644
--- a/files/templates/modals/emoji.html
+++ b/files/templates/modals/emoji.html
@@ -6,7 +6,7 @@
 				<div id="emoji-modal-tabs-container">
 					<ul class="nav nav-pills py-2" id="emoji-modal-tabs">
 						<li class="nav-item">
-							<a class="nav-link active emojitab" data-class-name="favorite" data-bs-toggle="tab" href="#">⭐ Favorite ⭐</a>
+							<button type="button" class="nav-link active emojitab" data-class-name="favorite" data-bs-toggle="tab">⭐ Favorite ⭐</button>
 						</li>
 					</ul>
 				</div>
diff --git a/files/templates/settings/personal.html b/files/templates/settings/personal.html
index 027774a8e..5e428fea7 100644
--- a/files/templates/settings/personal.html
+++ b/files/templates/settings/personal.html
@@ -272,17 +272,17 @@
 					{% set ns = namespace(slurtext='Enable if you would like to automatically replace slurs.', profanitytext='Enable if you would like to automatically replace profanities.') %}
 					{% if FEATURES['USERS_PERMANENT_WORD_FILTERS'] %}
 						{% if v.slurreplacer == 0 %}
-							{% set slurtext = 'Enable if you would like to automatically replace slurs. <a hidden id="slurreplacer-perma-link" href="#" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-slurreplacer">Make filter permanent for a badge!</a>' %}
+							{% set slurtext = 'Enable if you would like to automatically replace slurs. <button type="button" hidden id="slurreplacer-perma-link" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-slurreplacer">Make filter permanent for a badge!</button>' %}
 						{% elif v.slurreplacer == 1 %}
-							{% set slurtext = 'Enable if you would like to automatically replace slurs. <a id="slurreplacer-perma-link" href="#" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-slurreplacer">Make filter permanent for a badge!</a>' %}
+							{% set slurtext = 'Enable if you would like to automatically replace slurs. <button type="button" id="slurreplacer-perma-link" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-slurreplacer">Make filter permanent for a badge!</button>' %}
 						{% else %}
 							{% set slurtext = "You've enabled the slur replacer permanently! ✊🏿" %}
 						{% endif %}
 
 						{% if v.profanityreplacer == 0 %}
-							{% set profanitytext = 'Enable if you would like to automatically replace profanities. <a hidden id="profanityreplacer-perma-link" href="#" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-profanityreplacer">Make filter permanent for a badge!</a>' %}
+							{% set profanitytext = 'Enable if you would like to automatically replace profanities. <button type="button" hidden id="profanityreplacer-perma-link" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-profanityreplacer">Make filter permanent for a badge!</button>' %}
 										{% elif v.profanityreplacer == 1 %}
-							{% set profanitytext = 'Enable if you would like to automatically replace profanities. <a id="profanityreplacer-perma-link" href="#" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-profanityreplacer">Make filter permanent for a badge!</a>' %}
+							{% set profanitytext = 'Enable if you would like to automatically replace profanities. <button type="button" id="profanityreplacer-perma-link" class="text-primary" data-bs-toggle="modal" data-bs-target="#modal-profanityreplacer">Make filter permanent for a badge!</button>' %}
 						{% else %}
 							{% set profanitytext = "You've enabled the profanity replacer permanently! 😇" %}
 						{% endif %}